Subject: Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 07 May 2013 18:44:32 +0400

Hello.

    You shouldn't have posted this patch (and the subsequent series) 
during the merge window, as David will probably tell you.

On 07-05-2013 9:08, Nobuhiro Iwamatsu wrote:

> Some sh-eth devices may have two ether devices inside.

    You probably meant to say: "some SoCs may have two Ether devices 
inside".

> And the function of TSU is accessed from each ether device.
> In this case, sh-eth need to remap address using devm_ioremap(),
> without using devm_ioremap_resource().

    You could use devm_ioremap_resource() for the 1st Ether instance, 
and devm_ioremap() for the 2nd, couldn't you?

> tsu_shared_reg of sh_eth_cpu_data is used for this control.

> Signed-off-by: Nobuhiro Iwamatsu <[email-masked]>

WBR, Sergei