From: Roland Stigge <stigge@antcom•de>
To: Jingoo Han <jg1.han@samsung•com>
Cc: "'David S. Miller'" <davem@davemloft•net>,
netdev@vger•kernel.org,
'Wei Yongjun' <yongjun_wei@trendmicro•com.cn>,
Eric Dumazet <edumazet@google•com>
Subject: Re: [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata()
Date: Tue, 07 May 2013 18:22:59 +0200 [thread overview]
Message-ID: <51892A63.6060309@antcom.de> (raw)
In-Reply-To: <002601ce4add$888a35b0$999ea110$@samsung.com>
On 05/07/2013 06:44 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung•com>
Tested-by: Roland Stigge <stigge@antcom•de>
Acked-by: Roland Stigge <stigge@antcom•de>
> ---
> drivers/net/ethernet/nxp/lpc_eth.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index 55a5548..a061b93 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -1483,7 +1483,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
> return 0;
>
> err_out_unregister_netdev:
> - platform_set_drvdata(pdev, NULL);
> unregister_netdev(ndev);
> err_out_dma_unmap:
> if (!use_iram_for_net(&pldat->pdev->dev) ||
> @@ -1511,7 +1510,6 @@ static int lpc_eth_drv_remove(struct platform_device *pdev)
> struct netdata_local *pldat = netdev_priv(ndev);
>
> unregister_netdev(ndev);
> - platform_set_drvdata(pdev, NULL);
>
> if (!use_iram_for_net(&pldat->pdev->dev) ||
> pldat->dma_buff_size > lpc32xx_return_iram_size())
prev parent reply other threads:[~2013-05-07 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 4:44 [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 16:22 ` Roland Stigge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51892A63.6060309@antcom.de \
--to=stigge@antcom$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jg1.han@samsung$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yongjun_wei@trendmicro$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox