Subject: Re: [PATCH] bna: add missing iounmap() on error in bnad_init()

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 13 May 2013 18:01:45 +0400

Hello.

On 13-05-2013 11:26, Wei Yongjun wrote:

> From: Wei Yongjun <[email-masked]>

> Add the missing iounmap() before return from bnad_init()
> in the error handling case.
> Introduced by commit 01b54b1451853593739816a392485c4e2bee7dda
> (bna: tx rx cleanup fix).

> Signed-off-by: Wei Yongjun <[email-masked]>
> ---
>   drivers/net/ethernet/brocade/bna/bnad.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
> index ce4a030..59da9eb 100644
> --- a/drivers/net/ethernet/brocade/bna/bnad.c
> +++ b/drivers/net/ethernet/brocade/bna/bnad.c
> @@ -3237,8 +3237,10 @@ bnad_init(struct bnad *bnad,
>   	sprintf(bnad->wq_name, "%s_wq_%d", BNAD_NAME, bnad->id);
>   	bnad->work_q = create_singlethread_workqueue(bnad->wq_name);
>

    Empty line not needed here -- maybe it's time to delete it?

> -	if (!bnad->work_q)
> +	if (!bnad->work_q) {
> +		iounmap(bnad->bar0);
>   		return -ENOMEM;
> +	}
>   	return 0;
>   }

WBR, Sergei