public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Cong Wang <amwang@redhat•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>
Subject: Re: [Patch net-next v8 02/11] ipv6: make ip6_dst_hoplimit() static inline
Date: Fri, 17 May 2013 17:02:34 +0400	[thread overview]
Message-ID: <51962A6A.5000009@cogentembedded.com> (raw)
In-Reply-To: <1368750099-14086-3-git-send-email-amwang@redhat.com>

Hello.

On 17-05-2013 4:21, Cong Wang wrote:

> From: Cong Wang <amwang@redhat•com>

> It will be used by vxlan module, so move it from ipv6 module
> to core kernel. I think it is small enough to be inlined.

> Cc: David S. Miller <davem@davemloft•net>
> Signed-off-by: Cong Wang <amwang@redhat•com>
> ---
>   include/net/ip6_route.h |   23 +++++++++++++++++++++--
>   net/ipv6/route.c        |   19 -------------------
>   2 files changed, 21 insertions(+), 21 deletions(-)

> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
> index 260f83f..7e9192e 100644
> --- a/include/net/ip6_route.h
> +++ b/include/net/ip6_route.h
[...]
> @@ -201,4 +200,24 @@ static inline struct in6_addr *rt6_nexthop(struct rt6_info *rt, struct in6_addr
>   	return dest;
>   }
>
> +#if IS_ENABLED(CONFIG_IPV6)
> +static inline int ip6_dst_hoplimit(struct dst_entry *dst)
> +{
> +	int hoplimit = dst_metric_raw(dst, RTAX_HOPLIMIT);

     Empty line wouldn't hurt here, after the declaration, like below...

> +	if (hoplimit == 0) {
> +		struct net_device *dev = dst->dev;
> +		struct inet6_dev *idev;
> +
> +		rcu_read_lock();
> +		idev = __in6_dev_get(dev);
> +		if (idev)
> +			hoplimit = idev->cnf.hop_limit;
> +		else
> +			hoplimit = dev_net(dev)->ipv6.devconf_all->hop_limit;
> +		rcu_read_unlock();
> +	}
> +	return hoplimit;
> +}
> +#endif
> +

WBR, Sergei

  reply	other threads:[~2013-05-17 13:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  0:21 [Patch net-next v8 00/11] vxlan: add ipv6 support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 01/11] vxlan: defer vxlan init as late as possible Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 02/11] ipv6: make ip6_dst_hoplimit() static inline Cong Wang
2013-05-17 13:02   ` Sergei Shtylyov [this message]
2013-05-17 21:13   ` David Miller
2013-05-22  4:54     ` Cong Wang
2013-05-22  7:14       ` David Miller
2013-05-22 10:28         ` Cong Wang
2013-05-22 15:50           ` Mike Rapoport
2013-05-22 16:03             ` Cong Wang
2013-05-22 16:10               ` Mike Rapoport
2013-05-24  5:10                 ` Cong Wang
2013-05-24  5:15                 ` Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 03/11] ipv6: move ip6_local_out into core kernel Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 04/11] ipv6: export a stub for IPv6 symbols used by vxlan Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 05/11] ipv6: export in6addr_loopback to modules Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 06/11] vxlan: add ipv6 support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 07/11] vxlan: respect disable_ipv6 sysctl Cong Wang
2013-05-17 13:07   ` Sergei Shtylyov
2013-05-17  0:21 ` [Patch net-next v8 08/11] vxlan: add ipv6 route short circuit support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 09/11] vxlan: add ipv6 proxy support Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 10/11] vxlan: respect scope_id for ll addr Cong Wang
2013-05-17  0:21 ` [Patch net-next v8 11/11] ipv6: Add generic UDP Tunnel segmentation Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51962A6A.5000009@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded$(echo .)com \
    --cc=amwang@redhat$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox