From: "Holger Hoffstätte" <holger.hoffstaette@googlemail•com>
To: Francois Romieu <romieu@fr•zoreil.com>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Hayes Wang <hayeswang@realtek•com>,
Stefan Bader <stefan.bader@canonical•com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
Ben Hutchings <ben@decadent•org.uk>
Subject: Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets.
Date: Sat, 18 May 2013 16:42:52 +0200 [thread overview]
Message-ID: <5197936C.6090607@googlemail.com> (raw)
In-Reply-To: <20130518112446.GA21268@electric-eye.fr.zoreil.com>
On 18.05.2013 13:24, Francois Romieu wrote:
> 8168evl offloaded checksums are wrong since commit
> e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.")
> pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
> appear as UDP checksums which are wrong by the count of added bytes.
>
> It isn't worth compensating. Let the driver checksum.
>
> Due to the skb length changes, TSO code is moved before the Tx descriptor gets
> written.
>
> Signed-off-by: Francois Romieu <romieu@fr•zoreil.com>
Tested again, still working for me.
Tested-by: Holger Hoffstätte <holger.hoffstaette@googlemail•com>
-h
next prev parent reply other threads:[~2013-05-18 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 11:24 [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets Francois Romieu
2013-05-18 14:42 ` Holger Hoffstätte [this message]
2013-06-10 11:12 ` Holger Hoffstätte
2013-06-10 21:54 ` Francois Romieu
2013-05-20 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5197936C.6090607@googlemail.com \
--to=holger.hoffstaette@googlemail$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=hayeswang@realtek$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=stefan.bader@canonical$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox