From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, klassert@mathematik•tu-chemnitz.de,
tedheadster@gmail•com
Subject: Re: [PATCH v2] 3c59x: fix PCI resource management
Date: Sun, 19 May 2013 23:36:09 +0400 [thread overview]
Message-ID: <519929A9.7060509@cogentembedded.com> (raw)
In-Reply-To: <5187F512.4070104@cogentembedded.com>
Hello.
On 05/06/2013 10:23 PM, Sergei Shtylyov wrote:
>
>>>>> @@ -1215,12 +1217,13 @@ static int vortex_probe1(struct device *
>>>>> vp->mii.reg_num_mask = 0x1f;
>>>>>
>>>>> /* Makes sure rings are at least 16 byte aligned. */
>>>>> - vp->rx_ring = pci_alloc_consistent(pdev, sizeof(struct
>>>>> boom_rx_desc) *
>>>>> - RX_RING_SIZE
>>>>> - + sizeof(struct boom_tx_desc) * TX_RING_SIZE,
>>>>> - &vp->rx_ring_dma);
>>>>> + vp->rx_ring = pci_alloc_consistent(pdev,
>>>>> + sizeof(struct boom_rx_desc) * RX_RING_SIZE +
>>>>> + sizeof(struct boom_tx_desc) * TX_RING_SIZE,
>>>>> + &vp->rx_ring_dma);
>
>>>> This code was properly indented before your changes, but it isn't
>>>> afterwards.
>
>>> David, that's not my change, it's was Andrew Morton who changed
>>> that
>>> (in order not to cross 80 columns).
>
>> Ok, whoever submits this next needs to undo that.
>
> How about I completely drop this change (and maybe deal with it in
> a subsequent cleanup patch)?
It appears I had fixes for only a small part of
scripts/checkpatch.pl complaints
in this driver:
total: 114 errors, 428 warnings, 3327 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
I guess you don't need me to clean up the coding style in such an
old driver,
and I don't want to spend time on it either. So I'm going to let the lot
of overly
long lines in the driver live forever. :-)
WBR, Sergei
prev parent reply other threads:[~2013-05-19 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 22:40 [PATCH v2] 3c59x: fix PCI resource management Sergei Shtylyov
2013-05-01 22:49 ` Sergei Shtylyov
2013-05-02 17:40 ` Sergei Shtylyov
2013-05-06 16:20 ` David Miller
2013-05-06 17:29 ` Sergei Shtylyov
2013-05-06 17:53 ` David Miller
2013-05-06 18:23 ` Sergei Shtylyov
2013-05-06 18:59 ` David Miller
2013-05-06 19:33 ` Sergei Shtylyov
2013-05-06 19:57 ` David Miller
2013-05-19 19:36 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519929A9.7060509@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=klassert@mathematik$(echo .)tu-chemnitz.de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tedheadster@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox