public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora•be>
To: Chen Gang <gang.chen@asianux•com>
Cc: bart.de.schuymer@pandora•be, pablo@netfilter•org,
	kaber@trash•net, stephen@networkplumber•org,
	David Miller <davem@davemloft•net>,
	netfilter-devel@vger•kernel.org, netfilter@vger•kernel.org,
	coreteam@netfilter•org, bridge@lists•linux-foundation.org,
	netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] bridge: netfilter: using strlcpy() instead of strncpy()
Date: Sun, 19 May 2013 21:43:43 +0200	[thread overview]
Message-ID: <51992B6F.70309@pandora.be> (raw)
In-Reply-To: <5195E53A.4060406@asianux.com>

Op 17/05/2013 10:07, Chen Gang schreef:
>
> 'name' has already set all zero when it is defined, so not need let
> strncpy() to pad it again.
>
> 'name' is a string, better always let is NUL terminated, so use
> strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux•com>
Acked-by: Bart De Schuymer <bdschuym@pandora•be>

  reply	other threads:[~2013-05-19 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  8:07 [PATCH] bridge: netfilter: using strlcpy() instead of strncpy() Chen Gang
2013-05-19 19:43 ` Bart De Schuymer [this message]
2013-05-20  1:04   ` Chen Gang
2013-05-23 10:56 ` Pablo Neira Ayuso
2013-05-23 10:57   ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51992B6F.70309@pandora.be \
    --to=bdschuym@pandora$(echo .)be \
    --cc=bart.de.schuymer@pandora$(echo .)be \
    --cc=bridge@lists$(echo .)linux-foundation.org \
    --cc=coreteam@netfilter$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=gang.chen@asianux$(echo .)com \
    --cc=kaber@trash$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=netfilter@vger$(echo .)kernel.org \
    --cc=pablo@netfilter$(echo .)org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox