Subject: Re: [RESEND PATCH net-next] xfrm: add LINUX_MIB_XFRMACQUIREERROR statistic counter

From: Fan Du <[email-masked]>
Date: Tue, 21 May 2013 09:22:24 +0800

Hi, Sergei

On 2013年05月20日 22:11, Sergei Shtylyov wrote:
> Hello.
>
> On 20-05-2013 5:40, Fan Du wrote:
>
>> When host ping its peer, ICMP echo request packet triggers IPsec
>> policy, then host negotiates SA secret with its peer. After IKE
>> installed SA for OUT direction, but before SA for IN direction
>> installed, host get ICMP echo reply from its peer. At the time
>> being, the SA state for IN direction could be XFRM_STATE_ACQ,
>> then the received packet will be dropped after adding
>> LINUX_MIB_XFRMINSTATEINVALID statistic.
>
>> Adding a LINUX_MIB_XFRMACQUIREERROR statistic counter for such
>> scenario when SA in larval state is much clearer for user than
>> LINUX_MIB_XFRMINSTATEINVALID which indicates the SA is totally
>> bad.
>
>> Signed-off-by: Fan Du <[email-masked]>
>> ---
>> include/uapi/linux/snmp.h | 1 +
>> net/xfrm/xfrm_input.c | 5 +++++
>> net/xfrm/xfrm_proc.c | 1 +
>> 3 files changed, 7 insertions(+), 0 deletions(-)
>
>> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
>> index df2e8b4..3d072bf 100644
>> --- a/include/uapi/linux/snmp.h
>> +++ b/include/uapi/linux/snmp.h
>> @@ -287,6 +287,7 @@ enum
>> LINUX_MIB_XFRMOUTPOLERROR, /* XfrmOutPolError */
>> LINUX_MIB_XFRMFWDHDRERROR, /* XfrmFwdHdrError*/
>> LINUX_MIB_XFRMOUTSTATEINVALID, /* XfrmOutStateInvalid */
>> + LINUX_MIB_XFRMACQUIREERROR, /* XfrmAcquireError*/
>
> Please indent the comment with tabs and align with the above ones.

Thanks for the point, I will fix this in next round after reviewing from Steffen and others.

> WBR, Sergei

-- 
浮沉随浪只记今朝笑

--fan