From: David Vrabel <david.vrabel@citrix•com>
To: Wei Liu <wei.liu2@citrix•com>
Cc: <xen-devel@lists•xen.org>, <netdev@vger•kernel.org>,
<ian.campbell@citrix•com>, <konrad.wilk@oracle•com>
Subject: Re: [Xen-devel] [PATCH net-next 2/2] xen-netfront: split event channels feature support
Date: Tue, 21 May 2013 14:39:01 +0100 [thread overview]
Message-ID: <519B78F5.5020301@citrix.com> (raw)
In-Reply-To: <1369090931-27306-3-git-send-email-wei.liu2@citrix.com>
On 21/05/13 00:02, Wei Liu wrote:
> This patch adds a new feature called feature-split-event-channels for
> netfront, enabling it to handle TX and RX events separately.
>
> If netback does not support this feature, it falls back to use single event
> channel.
[...]
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1503,12 +1528,90 @@ static int xen_net_read_mac(struct xenbus_device *dev, u8 mac[])
> return 0;
> }
>
> +static int setup_netfront_single(struct netfront_info *info)
> +{
> + int err;
> +
> + err = xenbus_alloc_evtchn(info->xbdev, &info->tx_evtchn);
> + if (err < 0)
> + goto fail;
> +
> + err = bind_evtchn_to_irqhandler(info->tx_evtchn,
> + xennet_interrupt,
> + 0, info->netdev->name, info);
> + if (err < 0)
> + goto bind_fail;
> + info->rx_evtchn = info->tx_evtchn;
> + info->rx_irq = info->tx_irq = err;
> + dev_info(&info->xbdev->dev,
> + "single event channel, evtchn = %d, irq = %d\n",
> + info->tx_evtchn, info->tx_irq);
This message is pointless chatter as the information is available
elsewhere. Please remove.
> + dev_info(&info->xbdev->dev,
> + "split event channels, tx_evtchn/irq = %d/%d, rx_evtchn/irq = %d/%d",
> + info->tx_evtchn, info->tx_irq,
> + info->rx_evtchn, info->rx_irq);
Similarly.
Otherwise,
Reviewed-by: David Vrabel <david.vrabel@citrix•com>
David
next prev parent reply other threads:[~2013-05-21 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 23:02 [PATCH net-next 0/2] Xen network: split event channels support Wei Liu
2013-05-20 23:02 ` [PATCH net-next 1/2] xen-netback: split event channels feature support Wei Liu
2013-05-21 13:34 ` [Xen-devel] " David Vrabel
2013-05-21 14:33 ` Wei Liu
2013-05-20 23:02 ` [PATCH net-next 2/2] xen-netfront: " Wei Liu
2013-05-21 13:39 ` David Vrabel [this message]
2013-05-21 13:41 ` [Xen-devel] " Wei Liu
2013-05-21 16:28 ` Konrad Rzeszutek Wilk
2013-05-21 17:07 ` Wei Liu
2013-05-22 15:52 ` David Vrabel
2013-05-21 6:27 ` [PATCH net-next 0/2] Xen network: split event channels support David Miller
2013-05-21 8:00 ` Wei Liu
2013-05-21 8:13 ` David Miller
2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:34 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B78F5.5020301@citrix.com \
--to=david.vrabel@citrix$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox