public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: David Miller <davem@davemloft•net>
Cc: xiyou.wangcong@gmail•com, eric.dumazet@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next v3] sock_diag: notify packet socket creation/deletion
Date: Wed, 22 May 2013 13:49:03 +0200	[thread overview]
Message-ID: <519CB0AF.5090907@6wind.com> (raw)
In-Reply-To: <20130521.114356.1770768038835716108.davem@davemloft.net>

Le 21/05/2013 20:43, David Miller a écrit :
> From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> Date: Tue, 21 May 2013 17:14:50 +0200
>
>> Le 20/05/2013 08:29, David Miller a écrit :
>>> From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
>>> Date: Fri, 17 May 2013 16:25:38 +0200
>>>
>>>> With this patch, a netlink message is sent each time a packet socket
>>>> is created or deleted.  The framework is generic, so it's easy to
>>>> add the notification for other kind of sockets.
>>>>
>>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
>>>
>>> Just curious what you want to use this for.
>> Some HW (custom FPGA, ASICs, NPUs) are able to offload packet
>> captures, so it is required to notify them.
>
> I don't even want to hear about this until you have patches ready
> to submit to fully support such a facility.
Not sure to understand what you're expecting. In our case, configuration is done 
by a daemon, hence there is no other kernel patch to support this.

Note that this patch is still a complete feature, it allows to monitor AF_PACKET 
socket.
With a patched iproute2:

$ ss -ap0e -M
     Netid  State      Recv-Q Send-Q 
        Local Address:Port 
  Peer Address:Port
     p_dgr  UNCONN     0      0 
                    *:* 
              *        users:(("tcpdump",8630,3)) ino=29477 uid=0 sk=f53fbc00
del p_dgr  UNCONN     0      0 
                   *:* 
             *        users:(("tcpdump",8630,3)) ino=29477 uid=0 sk=f53fbc00

Will you accept the patch if I integrate the example in the commit log?

  reply	other threads:[~2013-05-22 11:49 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23 14:27 [PATCH net-next 0/5] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 1/5] packet_diag: disclose uid value Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 2/5] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 3/5] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-23 15:31   ` Eric Dumazet
2013-04-23 14:27 ` [PATCH net-next 4/5] sock_diag: notify packet socket creation/deletion Nicolas Dichtel
2013-04-23 14:27 ` [PATCH net-next 5/5] sock_diag: notify when filter change Nicolas Dichtel
2013-04-24  8:05   ` Cong Wang
2013-04-24  8:13     ` Nicolas Dichtel
2013-04-24 15:52       ` [PATCH net-next v2 0/5] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-24 15:52         ` [PATCH net-next v2 1/5] packet_diag: disclose uid value Nicolas Dichtel
2013-04-24 15:52         ` [PATCH net-next v2 2/5] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-24 15:52         ` [PATCH net-next v2 3/5] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-24 16:22           ` Eric Dumazet
2013-04-25  5:16             ` David Miller
2013-04-25  8:37             ` Nicolas Dichtel
2013-04-25  9:00               ` David Miller
2013-04-25 13:21                 ` [PATCH net-next v3 0/4] sock_diag: monitor packet sockets Nicolas Dichtel
2013-04-25 13:21                   ` [PATCH net-next v3 1/4] packet_diag: disclose uid value Nicolas Dichtel
2013-04-25 13:21                   ` [PATCH net-next v3 2/4] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-25 13:21                   ` [PATCH net-next v3 3/4] sock_diag: do not disclose sock ptr to all users Nicolas Dichtel
2013-04-25 15:32                     ` Eric Dumazet
2013-04-25 15:36                       ` Eric Dumazet
2013-04-25 16:45                         ` Nicolas Dichtel
2013-04-25 16:57                           ` Eric Dumazet
2013-04-25 16:53                       ` [PATCH net-next v4 0/3] packet_diag: enhance advertised infos Nicolas Dichtel
2013-04-25 16:53                         ` [PATCH net-next v4 1/3] packet_diag: disclose uid value Nicolas Dichtel
2013-04-25 16:53                         ` [PATCH net-next v4 2/3] packet_diag: disclose meminfo values Nicolas Dichtel
2013-04-25 16:53                         ` [PATCH net-next v4 3/3] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-29 17:22                         ` [PATCH net-next v4 0/3] packet_diag: enhance advertised infos David Miller
2013-04-25 13:21                   ` [PATCH net-next v3 4/4] sock_diag: allow to dump bpf filters Nicolas Dichtel
2013-04-25 13:51               ` [PATCH net-next v2 3/5] " Eric Dumazet
2013-04-24 15:52         ` [PATCH net-next v2 4/5] sock_diag: notify packet socket creation/deletion Nicolas Dichtel
2013-05-17 14:25           ` [PATCH net-next v3] " Nicolas Dichtel
2013-05-20  6:29             ` David Miller
2013-05-21 15:14               ` Nicolas Dichtel
2013-05-21 18:43                 ` David Miller
2013-05-22 11:49                   ` Nicolas Dichtel [this message]
2013-04-24 15:52         ` [PATCH net-next v2 5/5] sock_diag: notify when filter change Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519CB0AF.5090907@6wind.com \
    --to=nicolas.dichtel@6wind$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=xiyou.wangcong@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox