Subject: Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler_unregister

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 22 May 2013 22:30:19 +0400

Hello.

On 22-05-2013 12:42, dingtianhong wrote:

> commit 00cfec3748 (net: add a synchronize_net() ...) add a synchronize_net()

    Please specify complete summary line of this commit.

> in netdev_rx_handler_unregister() to guarantee the rx_handler  is NULL when
> rx_handler_data is a non NULL in rcu_read_lock().
>
> so the caller should not use netdev_rx_handler_unregister in atomic as it may
> schedule and sleep, the commit fcd99434f

    You forgot to specify the summary line of this commit.

> fix the bug in bond release, but the
> problem is no action to guarantee the rx_handler_data is NULL when bond release,
> so add synchronize_net() and fix it.

> This patch adds more comments to netdev_rx_handler_unregister().

> Signed-off-by: Ding Tianhong <[email-masked]>

WBR, Sergei