Subject: Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler_unregister

From: dingtianhong <[email-masked]>
Date: Thu, 23 May 2013 09:43:46 +0800

On 2013/5/23 2:30, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-05-2013 12:42, dingtianhong wrote:
> 
>> commit 00cfec3748 (net: add a synchronize_net() ...) add a synchronize_net()
> 
>    Please specify complete summary line of this commit.
> 

ok, I will modify and send again, just tell me your opinion, thanks.

>> in netdev_rx_handler_unregister() to guarantee the rx_handler  is NULL when
>> rx_handler_data is a non NULL in rcu_read_lock().
>>
>> so the caller should not use netdev_rx_handler_unregister in atomic as it may
>> schedule and sleep, the commit fcd99434f
> 
>    You forgot to specify the summary line of this commit.
> 
>> fix the bug in bond release, but the
>> problem is no action to guarantee the rx_handler_data is NULL when bond release,
>> so add synchronize_net() and fix it.
> 
>> This patch adds more comments to netdev_rx_handler_unregister().
> 
>> Signed-off-by: Ding Tianhong <[email-masked]>
> 
> WBR, Sergei
> 
> 
>