Subject: Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler_unregister

From: dingtianhong <[email-masked]>
Date: Thu, 23 May 2013 15:50:46 +0800

On 2013/5/23 9:52, Eric Dumazet wrote:
> On Thu, 2013-05-23 at 09:41 +0800, dingtianhong wrote:
> 
>> I totally understand the commit [1] and know the problem that you met at that time,
>> but its not a net core problem, its drivers problem, the function synchronize_net()
>> need to follow netdev_rx_handler_unregister() even though netdev_rx_handler_unregister()
>> has its own synchronize_net(), the commit [2] fcd99434f fix drivers problem follow your
>> opinion, but miss synchronize_net(),so add it.
>>
> 
> No, driver is fine.
> 
> You absolutely not explained why you believe this is needed.
> 
> After netdev_rx_handler_unregister(), no packet will be delivered to the
> bonding driver.
> 
> 
ok, I agree with the views of yours, it is no way to access the rx_handler_data after that.