From: Chen Gang <gang.chen@asianux•com>
To: Pablo Neira Ayuso <pablo@netfilter•org>
Cc: kaber@trash•net, kuznet@ms2•inr.ac.ru, jmorris@namei•org,
yoshfuji@linux-ipv6•org, David Miller <davem@davemloft•net>,
netfilter-devel@vger•kernel.org, netfilter@vger•kernel.org,
coreteam@netfilter•org, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] ipv4: netfilter: always let NUL terminated string ended by '\0'
Date: Thu, 23 May 2013 19:39:39 +0800 [thread overview]
Message-ID: <519DFFFB.40104@asianux.com> (raw)
In-Reply-To: <20130523110832.GB22553@localhost>
On 05/23/2013 07:08 PM, Pablo Neira Ayuso wrote:
> On Fri, May 17, 2013 at 04:39:15PM +0800, Chen Gang wrote:
>> >
>> > For NUL terminated string, better always be sure of ended by '\0'.
>> >
>> > 'pm' is 'struct ulog_packet_msg_t' which may be copied to user mode
>> > (defined in "include/uapi/..."), so can not use strlcpy() instead of.
> loginfo->prefix is always nul-terminated, as this is validated in
> checkentry. I don't think the kernel will take a non nul-terminated
> device name either.
>
>
Really it is.
And 'prefix' max length is 128 (NF_LOG_PREFIXLEN), and 'pm->prefix' max
length is 32 (ULOG_PREFIX_LEN), so we still need this patch, but need
improved.
So I should send patch v2.
Thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-05-23 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 8:39 [PATCH] ipv4: netfilter: always let NUL terminated string ended by '\0' Chen Gang
2013-05-23 11:08 ` Pablo Neira Ayuso
2013-05-23 11:39 ` Chen Gang [this message]
2013-05-23 11:49 ` Pablo Neira Ayuso
2013-05-23 11:59 ` Chen Gang
2013-05-23 11:50 ` [PATCH v2] " Chen Gang
2013-05-23 12:26 ` Pablo Neira Ayuso
2013-05-24 1:11 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519DFFFB.40104@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=netfilter@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox