Subject: Re: [PATCH] net: skbuff: use _RET_IP_

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 30 May 2013 01:43:39 +0400

Hello.

On 05/30/2013 01:09 AM, Davidlohr Bueso wrote:

> Use the already defined macro to pass the function return address.
>
> Signed-off-by: Davidlohr Bueso <[email-masked]>
> ---
>   net/core/skbuff.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index af9185d..0d06850 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -116,22 +116,22 @@ static const struct pipe_buf_operations sock_pipe_buf_ops = {
>    *	Keep out of line to prevent kernel bloat.
>    *	__builtin_return_address is not used because it is not always reliable.
>    */
> -static void skb_panic(struct sk_buff *skb, unsigned int sz, void *addr,
> +static void skb_panic(struct sk_buff *skb, unsigned int sz, unsigned long addr,
>   		      const char msg[])
>   {
> -	pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n",
> +	pr_emerg("%s: text:0x%lx len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n",

     Why not "text:%#lx" as already used in this string? It's equivalent 
to "0x%lx".

WBR, Sergei