From: "Jens Renner (EFE)" <renner@efe-gmbh•de>
To: Michal Simek <michal.simek@xilinx•com>
Cc: Michal Simek <monstr@monstr•eu>, netdev@vger•kernel.org
Subject: Re: [PATCH v2 0/6] Emaclite patches
Date: Fri, 31 May 2013 11:10:23 +0200 [thread overview]
Message-ID: <51A868FF.5070903@efe-gmbh.de> (raw)
In-Reply-To: <cover.1369909618.git.michal.simek@xilinx.com>
Am 30.05.2013 12:28, schrieb Michal Simek:
> I have separated these emaclite patches from phy patches because it is
> easier for creating new versions.
>
> Thanks, Michal
>
> Changes in v2: - Fix __raw_iowrite() to pass correct parameters -
> s/Corrent/Correct/ in patch description
>
> Michal Simek (6): net: emaclite: Report failures in mdio setup net:
> emaclite: Support multiple phys connected to one MDIO bus net: emaclite:
> Let's make xemaclite_adjust_link static net: emaclite: Do not use
> microblaze and ppc IO functions net: emaclite: Enable emaclite for Xilinx
> Arm Zynq platform net: emaclite: Update driver header
>
> drivers/net/ethernet/xilinx/Kconfig | 4 +-
> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 169
> ++++++++++++++------------ 2 files changed, 95 insertions(+), 78
> deletions(-)
Works without problems on our Microblaze platform (as far as the patches affect
our functionality). MDIO verbosity has been tested ok.
> @@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp,
struct device *dev)
> XEL_MDIOCTRL_MDIOEN_MASK);
>
> bus = mdiobus_alloc(); - if (!bus) + if (!bus) { + dev_err(dev, "Failed to
> allocal mdiobus\n"); return -ENOMEM; + }
>
> of_address_to_resource(np, 0, &res); snprintf(bus->id, MII_BUS_ID_SIZE,
> "%.8llx",
Shouldn't the wording be "allocate" instead of "allocal" in PATCH v2 1/6 (net:
emaclite: Report failures in mdio setup)?
Regards
Jens.
next prev parent reply other threads:[~2013-05-31 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 10:28 [PATCH v2 0/6] Emaclite patches Michal Simek
2013-05-30 10:28 ` [PATCH v2 1/6] net: emaclite: Report failures in mdio setup Michal Simek
2013-05-30 10:28 ` [PATCH v2 2/6] net: emaclite: Support multiple phys connected to one MDIO bus Michal Simek
2013-05-30 10:28 ` [PATCH v2 3/6] net: emaclite: Let's make xemaclite_adjust_link static Michal Simek
2013-05-30 10:28 ` [PATCH v2 4/6] net: emaclite: Do not use microblaze and ppc IO functions Michal Simek
2013-05-30 10:28 ` [PATCH v2 5/6] net: emaclite: Enable emaclite for Xilinx Arm Zynq platform Michal Simek
2013-05-30 10:28 ` [PATCH v2 6/6] net: emaclite: Update driver header Michal Simek
2013-05-31 0:14 ` [PATCH v2 0/6] Emaclite patches David Miller
2013-05-31 9:10 ` Jens Renner (EFE) [this message]
2013-05-31 9:15 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A868FF.5070903@efe-gmbh.de \
--to=renner@efe-gmbh$(echo .)de \
--cc=michal.simek@xilinx$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox