From: Chen Gang <gang.chen@asianux•com>
To: Simon Horman <horms@verge•net.au>
Cc: Pablo Neira Ayuso <pablo@netfilter•org>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, netfilter-devel@vger•kernel.org
Subject: Re: [PATCH net-next v3] netfilter: Correct calculation using skb->tail and skb-network_header
Date: Mon, 03 Jun 2013 17:06:53 +0800 [thread overview]
Message-ID: <51AC5CAD.6040204@asianux.com> (raw)
In-Reply-To: <1369967969-32375-1-git-send-email-horms@verge.net.au>
On 05/31/2013 10:39 AM, Simon Horman wrote:
> This corrects an regression introduced by "net: Use 16bits for *_headers
> fields of struct skbuff" when NET_SKBUFF_DATA_USES_OFFSET is not set. In
> that case skb->tail will be a pointer whereas skb->network_header
> will be an offset from head. This is corrected by using wrappers that
> ensure that calculations are always made using pointers.
>
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Reported-by: Chen Gang <gang.chen@asianux•com>
> Signed-off-by: Simon Horman <horms@verge•net.au>
>
> --
> v3
> * Add net-next to subject prefix
>
> v2
> * Use skb_tail_pointer() to ensure the tail portion of the calculation is
> always a pointer - it is not if NET_SKBUFF_DATA_USES_OFFSET is not set.
Thanks.
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-06-03 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 2:39 [PATCH net-next v3] netfilter: Correct calculation using skb->tail and skb-network_header Simon Horman
2013-05-31 23:38 ` David Miller
2013-06-03 9:06 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC5CAD.6040204@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=horms@verge$(echo .)net.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox