Subject: Re: [net-next PATCH v4 3/5] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone

From: Mugunthan V N <[email-masked]>
Date: Thu, 6 Jun 2013 13:51:46 +0530

On 6/6/2013 12:36 PM, Florian Vaussard wrote:
> Hello,
>
> On 06/05/2013 07:08 PM, Mugunthan V N wrote:
>> Add pinmux configurations for MII based CPSW ethernet to am335x-bone.
>> In this patch, only single named mode/state is added and these pins
>> are configured during pinctrl driver initialization.
>>
>> Default mode is nothing but the values required for the module during
>> active state. With this configurations module is functional as
>> expected.
>>
>> Todo:
>> - if an idle state is available for pins, add support for it.
>>
>> Signed-off-by: Mugunthan V N <[email-masked]>
>> ---
>>   arch/arm/boot/dts/am335x-bone.dts |   38 
>> +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 38 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am335x-bone.dts 
>> b/arch/arm/boot/dts/am335x-bone.dts
>> index 4b5a8e0..008a13b 100644
>> --- a/arch/arm/boot/dts/am335x-bone.dts
>> +++ b/arch/arm/boot/dts/am335x-bone.dts
>> @@ -36,6 +36,33 @@
>>                   0x60 0x17    /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | 
>> MODE7 */
>>               >;
>>           };
>> +
>> +        cpsw_default: cpsw_default {
>> +            pinctrl-single,pins = <
>> +                /* Slave 1 */
>> +                0x110 0x20    /* mii1_rxerr.mii1_rxerr, MODE0 | 
>> INPUT */
>
> Here I guess that the comment should be INPUT_PULLDOWN, instead of INPUT.
Good catch, I will modify this and submit next version today.
>
>> +                0x114 0x0    /* mii1_txen.mii1_txen, MODE0 | OUTPUT */
>
> As bit PULLUDENABLE is 0, the pulldown is enabled according to the 
> TRM, right?
> Is this a desirable behaviour, as it will consume power when 
> outputting a high level?
This is the desirable behavior.
> And consequently, the comment should probably be OUTPUT_PULLDOWN, no?
Will update this in next version of patch series.

Regards
Mugunthan V N