Subject: Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets.

From: Holger Hoffstätte<[email-masked]>
Date: Mon, 10 Jun 2013 13:12:10 +0200

On 18.05.2013 16:42, Holger Hoffstätte wrote:
> On 18.05.2013 13:24, Francois Romieu wrote:
>> 8168evl offloaded checksums are wrong since commit
>> e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.")
>> pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
>> appear as UDP checksums which are wrong by the count of added bytes.
>>
>> It isn't worth compensating. Let the driver checksum.
>>
>> Due to the skb length changes, TSO code is moved before the Tx descriptor gets
>> written.
>>
>> Signed-off-by: Francois Romieu <[email-masked]>
> 
> Tested again, still working for me.
> 
> Tested-by: Holger Hoffstätte <[email-masked]>

ping:

As far as I can tell this patch is still not in -stable 3.9.5 or queued
up for the next iteration.

Commit in Linus' tree is b423e9ae49d78ea3f53b131c8d5a6087aed16fd6

thanks :)

-h