From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas•com>
Cc: netdev@vger•kernel.org, nobuhiro.iwamatsu.yj@renesas•com,
linux-sh@vger•kernel.org
Subject: Re: [PATCH] sh_eth: get R8A7740 Rx descriptor word 0 shift out of #ifdef
Date: Tue, 11 Jun 2013 17:01:34 +0400 [thread overview]
Message-ID: <51B71FAE.6050005@cogentembedded.com> (raw)
In-Reply-To: <51B6B702.6070005@renesas.com>
Hello.
On 11-06-2013 9:34, Shimoda, Yoshihiro wrote:
>> The only R8A7740 specific #ifdef hindering ARM multiplatform build is left in
>> sh_eth_rx(): it covers a very strange code shifting Rx buffer descriptor word 0
>> by 16 (which should cause Rx length error to be logged on every buffer several
>> lines later). Get rid of the #ifdef by adding 'shift_rd0' field to the 'struct
>> sh_eth_cpu_data', making the shift dependent on it, and setting it to 1 for the
>> R8A7740 case...
> This very strange code was from the first R8A7740 supporting patch I sent.
> I should have shifted the RD_RFS values (from RD_RFS1 to RD_RFS10) if R8A7740.
> In other words, since the desc_status also has RDFEND, I should have not shifted
> the desc_status before the driver checked the RDFEND.
> So, I think we have to modify this "desc_status >>= 16" timing.
> Should I submit such a patch first?
Yes, that would be preferable. Just give it a good description.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
prev parent reply other threads:[~2013-06-11 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 20:22 [PATCH] sh_eth: get R8A7740 Rx descriptor word 0 shift out of #ifdef Sergei Shtylyov
2013-06-11 5:34 ` Shimoda, Yoshihiro
2013-06-11 13:01 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B71FAE.6050005@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox