From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas•com>
Cc: netdev@vger•kernel.org, SH-Linux <linux-sh@vger•kernel.org>
Subject: Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
Date: Wed, 12 Jun 2013 23:25:15 +0400 [thread overview]
Message-ID: <51B8CB1B.9020304@cogentembedded.com> (raw)
In-Reply-To: <51B7CFFB.7090801@renesas.com>
On 06/12/2013 05:33 AM, Shimoda, Yoshihiro wrote:
> This patch fixes an issue that the driver increments the "RX length error"
> on every buffer in sh_eth_rx() if the R8A7740.
> This patch also adds a description about the Receive Frame Status bits.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
> ---
> This patch is based on the latest net-next.git.
> drivers/net/ethernet/renesas/sh_eth.c | 15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 43d8490..ab2f9c2 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1260,16 +1260,23 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status)
> desc_status = edmac_to_cpu(mdp, rxdesc->status);
> pkt_len = rxdesc->frame_length;
>
> -#if defined(CONFIG_ARCH_R8A7740)
> - desc_status >>= 16;
> -#endif
> -
> if (--boguscnt < 0)
> break;
>
> if (!(desc_status & RDFEND))
> ndev->stats.rx_length_errors++;
>
> +#if defined(CONFIG_ARCH_R8A7740)
> + /*
> + * In case of almost GETHER/ETHERs, the Receive Frame State
Erm, minor nit: it seems you forgot "all" after "almost". Hence it's
probably worth resubmitting...
> + * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
> + * bit 0. However, in case of the R8A7740's GETHER, the RFS
> + * bits are from bit 25 to bit 16. So, the driver needs right
> + * shifting by 16.
> + */
> + desc_status >>= 16;
> +#endif
> +
WBR, Sergei
next prev parent reply other threads:[~2013-06-12 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 1:33 [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740 Shimoda, Yoshihiro
2013-06-12 14:15 ` Sergei Shtylyov
2013-06-12 19:13 ` Sergei Shtylyov
2013-06-12 19:55 ` David Miller
2013-06-12 20:03 ` Sergei Shtylyov
2013-06-12 19:25 ` Sergei Shtylyov [this message]
2013-06-13 0:57 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B8CB1B.9020304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox