Subject: Re: [PATCH 1/1] fec: Add support to restart autonegotiate

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 17 Jun 2013 17:44:46 +0400

Hello.

On 17-06-2013 4:04, [email-masked] wrote:

> From: Chris <[email-masked]>

> Add ethtool operation to restart autonegotiation via the PHY.

> Also cleanup two whitespace errors that break kernel guidelines.

    This "also" is asking for another patch.

> Tested on i.MX28EVK.

> Signed-off-by: Chris <[email-masked]>

     You must specify your full name.

> ---
>   drivers/net/ethernet/freescale/fec_main.c | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index a667015..c6be728 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -150,7 +150,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
>   #define	FEC_FLASHMAC	0xf0006000
>   #elif defined(CONFIG_CANCam)
>   #define	FEC_FLASHMAC	0xf0020000
> -#elif defined (CONFIG_M5272C3)
> +#elif defined(CONFIG_M5272C3)
>   #define	FEC_FLASHMAC	(0xffe04000 + 4)
>   #elif defined(CONFIG_MOD5272)
>   #define FEC_FLASHMAC	0xffc0406b
> @@ -1206,8 +1206,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
>   	if (id_entry->driver_data & FEC_QUIRK_HAS_GBIT) {
>   		phy_dev->supported &= PHY_GBIT_FEATURES;
>   		phy_dev->supported |= SUPPORTED_Pause;
> -	}
> -	else
> +	} else
>   		phy_dev->supported &= PHY_BASIC_FEATURES;

    According to Documentation/CodingStyle, *else* branch should have 
{}, as *if* branch has it.

WBR, Sergei