Subject: Re: [PATCH] vlan: restore ethtool ABI to control VLAN hardware acceleration

From: Fernando Luis Vazquez Cao <[email-masked]>
Date: Tue, 18 Jun 2013 10:38:14 +0900

On 2013年06月18日 09:10, David Miller wrote:
> From: Ben Hutchings <[email-masked]>
> Date: Mon, 17 Jun 2013 19:20:54 +0100
>
>> On Mon, 2013-06-17 at 11:28 +0900, Fernando Luis Vázquez Cao wrote:
>>> As part of the push to add 802.1ad server provider tagging support to the
>>> kernel the VLAN features flags were renamed. Unfortunately the kernel name
>>> for the VLAN hardware acceleration features that the kernel shows user space
>>> was included in the rename, which broke ethtool (txvlan and rxvlan options
>>> do not work).
>> I expected something like that and said this was an ABI change, but
>> apparently my objection wasn't sufficient.
>>
>>> This patch restores the original names, i.e. the original ABI.
>>> If we wanted to make clear to users that we are refering to CTAGs we can
>>> always change ethtool's short_name and long_name for these features (for
>>> example something along the lines of txvlan -> txvlan-ctag, tx-vlan-offload ->
>>> tx-vlan-ctag-offload).
>>>
>>> Cc: Patrick McHardy <[email-masked]>
>>> Cc: David S. Miller <[email-masked]>
>>> Cc: [email-masked]
>>> Signed-off-by: Fernando Luis Vazquez Cao <[email-masked]>
>> Reviewed-by: Ben Hutchings <[email-masked]>
> Ok Ben you were indeed right :-)
>
> Applied, thanks.

Could you get this to Linus before 3.10 is out?

Thanks,
Fernando