From: Gao feng <gaofeng@cn•fujitsu.com>
To: David Miller <davem@davemloft•net>
Cc: ebiederm@xmission•com, netdev@vger•kernel.org
Subject: Re: [PATCH v2 4/4] neigh: don't leak default parms to uninitial netns
Date: Thu, 20 Jun 2013 09:18:48 +0800 [thread overview]
Message-ID: <51C25878.2070302@cn.fujitsu.com> (raw)
In-Reply-To: <20130619.180505.1958820391321832484.davem@davemloft.net>
On 06/20/2013 09:05 AM, David Miller wrote:
> From: Gao feng <gaofeng@cn•fujitsu.com>
> Date: Fri, 14 Jun 2013 10:06:47 +0800
>
>> Only allow initial net namespace to get default parms
>> through netlink.
>>
>> Signed-off-by: Gao feng <gaofeng@cn•fujitsu.com>
>
> Disallowing changes to the default neigh parms is fine, but there is no
> reason to forbid seeing what default neigh parms will be used in a given
> network namespace just because it isn't &init_net.
>
Yes, we can make sure un-init net namespace can't do harm to default neigh parms,
it's enough.
> I don't see why you want to restrict this at all.
>
> I'm not applying these patches, sorry.
You can just drop this one, are there some problems with the other 3 patches?
next prev parent reply other threads:[~2013-06-20 1:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 2:06 [PATCH v2 1/4] neigh: no need to call lookup_neigh_parms in neigh_parms_alloc Gao feng
2013-06-14 2:06 ` [PATCH v2 2/4] neigh: only allow init_net to change the default neigh_parms Gao feng
2013-06-14 2:06 ` [PATCH v2 3/4] neigh: disallow un-init_net to change thresh of neigh Gao feng
2013-06-14 2:06 ` [PATCH v2 4/4] neigh: don't leak default parms to uninitial netns Gao feng
2013-06-20 1:05 ` David Miller
2013-06-20 1:18 ` Gao feng [this message]
2013-06-20 1:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C25878.2070302@cn.fujitsu.com \
--to=gaofeng@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox