From: Chen Gang <gang.chen@asianux•com>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Richard Weinberger <richard@nod•at>,
David Miller <davem@davemloft•net>,
Richard Cochran <richardcochran@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] drivers/ptp/Kconfig: add "depends on HAS_IOMEM" for 'PTP_1588_CLOCK_PCH'
Date: Mon, 01 Jul 2013 15:47:42 +0800 [thread overview]
Message-ID: <51D1341E.6090908@asianux.com> (raw)
In-Reply-To: <CAMuHMdXnO8-9riLcFLQfMoWJRgy7gtQJdKkHZNR0D5eaM4=oxQ@mail.gmail.com>
On 07/01/2013 03:32 PM, Geert Uytterhoeven wrote:
> On Mon, Jul 1, 2013 at 8:44 AM, Chen Gang <gang.chen@asianux•com> wrote:
>> > On 07/01/2013 02:34 PM, Richard Weinberger wrote:
>>>> >>> config COMPILE_TEST
>>>>> >>> > bool "Compile also drivers which will not load"
>>>>> >>> > default n
>>>>> >>> > help
>>>>> >>> > Some drivers can be compiled on a different platform than they are
>>>>> >>> > intended to be run on. Despite they cannot be loaded there (or even
>>>>> >>> > when they load they cannot be used due to missing HW support),
>>>>> >>> > developers still, opposing to distributors, might want to build such
>>>>> >>> > drivers to compile-test them.
>>>>> >>> >
>>>>> >>> > If you are a developer and want to build everything available, say Y
>>>>> >>> > here. If you are a user/distributor, say N here to exclude useless
>>>>> >>> > drivers to be distributed.
>>>>> >>> >
>>>>> >>> > I guess, 'COMPILE_TEST' is really useful for UML.
>>> >> No.
>>> >>
>>> >> We have explained you more than once what the deal and why UML does not
>>> >> have ioremap() and friends.
>> >
>> > This time, it is not for UML, it is for 'COMPILE_TEST': the
>> > 'asm-generic' whether need consider it.
> COMPILE_TEST is only meant to be used as a dependency in Kconfig files,
> to make drivers that cannot work due to missing hardware invisible when
> configuring your kernel.
>
Why "Despite they cannot be loaded there (or even when they load they
cannot be used due to missing HW support)" ?
> There should be no #ifdefs in actual code that check for (the lack of)
> CONFIG_COMPILE_TEST.
In ideal world, it should be no #ifdefs for all "CONFIG_*" in 'normal code'.
But "asm-generic" are not belong to 'normal code', it is one of the main
place to process "CONFIG_*".
If the platforms need support 'COMPILE_TEST', the asm-generic is the
main place for implementing it.
So I think our focus is on "whether the platforms guys need support
'COMPILE_TEST" for modules guys".
Thanks
--
Chen Gang
next prev parent reply other threads:[~2013-07-01 7:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 0:52 [PATCH] drivers/ptp/Kconfig: add "depends on HAS_IOMEM" for 'PTP_1588_CLOCK_PCH' Chen Gang
2013-06-27 6:48 ` Geert Uytterhoeven
2013-06-27 8:21 ` Chen Gang
2013-06-29 4:23 ` David Miller
2013-07-01 1:34 ` Chen Gang
2013-07-01 5:40 ` Richard Weinberger
2013-07-01 6:09 ` Chen Gang
2013-07-01 6:34 ` Richard Weinberger
2013-07-01 6:44 ` Chen Gang
2013-07-01 7:32 ` Geert Uytterhoeven
2013-07-01 7:47 ` Chen Gang [this message]
2013-07-01 7:56 ` Geert Uytterhoeven
2013-07-01 8:17 ` Chen Gang
2013-07-01 11:12 ` Richard Weinberger
2013-07-01 11:19 ` Geert Uytterhoeven
2013-07-02 0:57 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D1341E.6090908@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=geert@linux-m68k$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richard@nod$(echo .)at \
--cc=richardcochran@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox