Subject: Re: [PATCH net] ipv6: ip6_append_data_mtu did not care about pmtudisc and frag_size

From: Gao feng <[email-masked]>
Date: Tue, 02 Jul 2013 13:42:24 +0800

On 07/02/2013 01:18 PM, Hannes Frederic Sowa wrote:
> On Tue, Jul 02, 2013 at 07:13:21AM +0200, Hannes Frederic Sowa wrote:
>> On Tue, Jul 02, 2013 at 10:46:38AM +0800, Gao feng wrote:
>>> On 07/02/2013 02:17 AM, Hannes Frederic Sowa wrote:
>>> No need to pass ipv6_pinfo to ip6_append_data_mtu, the below is enough.
>>>
>>> *mtu = min(*mtu, (np->pmtudisc == IPV6_PMTUDISC_DO) ?
>>> 				rt->dst.dev->mtu :
>>> 				dst_mtu(rt->dst.path);
>>>
>>> This patch looks good go me.
>>>
>>> Acked-by: Gao feng <[email-masked]>
>>>
>>> Thanks!
>>
>> Thanks for your feedback, I will incooperate it in my next version of
>> the patch. Actually, I seem to have done an error in the above code,
>> i need to replace IPV6_PMTUDISC_DO with IPV6_PMTUDISC_WANT. Does your
>> Acked-by still hold?
> 
> Erk, err, IPV6_PMTUDISC_PROBE was what i meant.
> 
> 
Yes, IPV6_PMTUDISC_PROBE is more reasonable. you can hold my ack.