From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Fan Du <fan.du@windriver•com>
Cc: yoshfuji@linux-ipv6•org, jmorris@namei•org, kuznet@ms2•inr.ac.ru,
davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization
Date: Thu, 11 Jul 2013 09:32:09 +0200 [thread overview]
Message-ID: <51DE5F79.7080202@6wind.com> (raw)
In-Reply-To: <1373502442-32403-1-git-send-email-fan.du@windriver.com>
Le 11/07/2013 02:27, Fan Du a écrit :
> Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
> has zeroed the rest of rt excluding the first dst memember.
>
> Signed-off-by: Fan Du <fan.du@windriver•com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> ---
> net/ipv6/route.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 7ca87b3..b88f99f 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -278,7 +278,6 @@ static inline struct rt6_info *ip6_dst_alloc(struct net *net,
> rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
> rt->rt6i_genid = rt_genid(net);
> INIT_LIST_HEAD(&rt->rt6i_siblings);
> - rt->rt6i_nsiblings = 0;
> }
> return rt;
> }
>
next prev parent reply other threads:[~2013-07-11 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 0:27 [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization Fan Du
2013-07-11 7:32 ` Nicolas Dichtel [this message]
2013-07-11 10:16 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE5F79.7080202@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fan.du@windriver$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox