Subject: Re: [PATCH 05/50] USB: misc: uss720: spin_lock in complete() cleanup

From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/[email-masked]>
Date: Thu, 11 Jul 2013 16:15:22 +0400

Hello.

On 11-07-2013 13:05, Ming Lei wrote:

> Complete() will be run with interrupt enabled, so change to
> spin_lock_irqsave().

> Signed-off-by: Ming Lei <[email-masked]>
> ---
>   drivers/usb/misc/uss720.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

> diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
> index e129cf6..f7d15e8 100644
> --- a/drivers/usb/misc/uss720.c
> +++ b/drivers/usb/misc/uss720.c
> @@ -121,6 +121,7 @@ static void async_complete(struct urb *urb)
>   		dev_err(&urb->dev->dev, "async_complete: urb error %d\n",
>   			status);
>   	} else if (rq->dr.bRequest == 3) {
> +		unsigned long flags;

    Empty line wouldn't hurt here, after declaration.

>   		memcpy(priv->reg, rq->reg, sizeof(priv->reg));

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html