From: Thomas-Mich Richter <tmricht@linux•vnet.ibm.com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] vxlan fdb replace an existing entry
Date: Fri, 12 Jul 2013 09:18:30 +0200 [thread overview]
Message-ID: <51DFADC6.2050309@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130711085638.75690edf@nehalam.linuxnetplumber.net>
On 07/11/2013 05:56 PM, Stephen Hemminger wrote:
> On Thu, 11 Jul 2013 12:28:19 +0200
> Thomas Richter <tmricht@linux•vnet.ibm.com> wrote:
>
>> Add support to replace an existing entry found in the
>> vxlan fdb database. The entry in question is identified
>> by its unicast mac address and the destination information
>> is changed. If the entry is not found, it is added in the
>> forwarding database. This is similar to changing an entry
>> in the neighbour table.
>>
>> Multicast mac addresses can not be changed with the replace
>> option.
>>
>> This is useful for virtual machine migration when the
>> destination of a target virtual machine changes. The replace
>> feature can be used instead of delete followed by add.
>>
>> Signed-off-by: Thomas Richter <tmricht@linux•vnet.ibm.com>
>> ---
>> drivers/net/vxlan.c | 40 +++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 39 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
>> index 227b54a..17681c6 100644
>> --- a/drivers/net/vxlan.c
>> +++ b/drivers/net/vxlan.c
>> @@ -42,7 +42,7 @@
>> #include <net/net_namespace.h>
>> #include <net/netns/generic.h>
>>
>> -#define VXLAN_VERSION "0.1"
>> +#define VXLAN_VERSION "0.1tmr3"
>
> I am ok with everything but the weird version string.
> Just make it 0.2 or 0.1.1 if you need it
Just send a version V2 with weird version string change removed.
--
Thomas Richter, Dept 3250, IBM LTC Boeblingen, Data Center Networking
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
prev parent reply other threads:[~2013-07-12 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 10:28 [PATCH 1/2] vxlan fdb replace an existing entry Thomas Richter
2013-07-11 10:28 ` [PATCH 2/2] macvlan fdb replace support Thomas Richter
2013-07-11 14:26 ` [PATCH 1/2] vxlan fdb replace an existing entry David Stevens
2013-07-11 15:56 ` Stephen Hemminger
2013-07-12 7:18 ` Thomas-Mich Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DFADC6.2050309@linux.vnet.ibm.com \
--to=tmricht@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox