Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs

From: Mugunthan V N <[email-masked]>
Date: Sat, 20 Jul 2013 13:30:07 +0530

On 7/20/2013 6:02 AM, David Miller wrote:
> From: Mugunthan V N <[email-masked]>
> Date: Fri, 19 Jul 2013 19:37:21 +0530
>
>> Add support to show CPSW hardware statistics to user via ethtool get_regs
>> ops so user can find if there were any error reported or the system is
>> over loaded duing hagh data rate transfer.
>>
>> Signed-off-by: Mugunthan V N <[email-masked]>
> This is not the correct way to provide this functionality.  ->get_regs()
> is for dumping the raw hardware registers to userspace for low level
> debugging purposes, not for providing HW specific statistics.
>
> The correct thing to do is provide an appropriate implementation of
> the ->get_strings() and ->get_ethtool_stats() methods.
Will change the implementation and resubmit the patch.

Regards
Mugunthan V N