Subject: Re: [PATCH net-next] tuntap: hardware vlan tx support

From: Jason Wang <[email-masked]>
Date: Wed, 24 Jul 2013 13:55:14 +0800

On 07/23/2013 11:53 PM, Stephen Hemminger wrote:
> On Tue, 23 Jul 2013 15:15:48 +0800
> Jason Wang <[email-masked]> wrote:
>
>> +		struct {
>> +			__be16 h_vlan_proto;
>> +			__be16 h_vlan_TCI;
>> +		} veth;
> Don't you want to use struct vlan_hdr here? 

There's no need to care encapsulated proto here. In fact, we just
emulate the hardware inserting of 802.1Q header. So only skb->vlan_tci
and skb->vlan_proto needs to be cared.
> Your definition puts the two fields out of order?

It's order is same as struct vlan_ethhdr. Did you see any issue?