From: Nikolay Aleksandrov <nikolay@redhat•com>
To: netdev@vger•kernel.org
Cc: davem@davemloft•net, vfalico@redhat•com, fubar@us•ibm.com,
jhs@mojatatu•com
Subject: Re: [PATCH net 1/2] vlan: make vlan_dev_real_dev work over stacked vlans
Date: Sun, 04 Aug 2013 04:17:43 +0200 [thread overview]
Message-ID: <51FDB9C7.4090703@redhat.com> (raw)
In-Reply-To: <1375560467-1604-1-git-send-email-nikolay@redhat.com>
On 08/03/2013 10:07 PM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <Nikolay Aleksandrov nikolay@redhat•com>
>
> Sometimes we might have stacked vlans on top of each other, and we're
> interested in the first non-vlan real device on the path, so transform
> vlan_dev_real_dev to go over the stacked vlans and extract the first
> non-vlan device.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat•com>
> ---
> net/8021q/vlan_core.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c
> index 4a78c4d..6ee48aa 100644
> --- a/net/8021q/vlan_core.c
> +++ b/net/8021q/vlan_core.c
> @@ -91,7 +91,12 @@ EXPORT_SYMBOL(__vlan_find_dev_deep);
>
> struct net_device *vlan_dev_real_dev(const struct net_device *dev)
> {
> - return vlan_dev_priv(dev)->real_dev;
> + struct net_device *ret = vlan_dev_priv(dev)->real_dev;
> +
> + while (is_vlan_dev(ret))
> + ret = vlan_dev_priv(ret)->real_dev;
> +
> + return ret;
> }
> EXPORT_SYMBOL(vlan_dev_real_dev);
>
>
I have one question - why not make it possible to call vlan_dev_real_dev()
with any device (vlan/non-vlan) and make it return a real device in all
cases (e.g. if it's a non-vlan device simply return it) ?
In the terms of the code above - simply change:
struct net_device *ret = vlan_dev_priv(dev)->real_dev;
with
struct net_device *ret = dev;
This way we'll be able to simplify calls like if (is_vlan_dev(dev)) (or the
flag check alternative of this) to just vlan_dev_real_dev(). The old call
sites of this function will still work properly.
Nik
next prev parent reply other threads:[~2013-08-04 2:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 20:07 [PATCH net 1/2] vlan: make vlan_dev_real_dev work over stacked vlans Nikolay Aleksandrov
2013-08-03 20:07 ` [PATCH net v2 2/2] net_sched: make dev_trans_start return vlan's real dev trans_start Nikolay Aleksandrov
2013-08-03 20:12 ` Veaceslav Falico
2013-08-05 19:18 ` David Miller
2013-08-03 20:11 ` [PATCH net 1/2] vlan: make vlan_dev_real_dev work over stacked vlans Veaceslav Falico
2013-08-04 2:17 ` Nikolay Aleksandrov [this message]
2013-08-05 6:58 ` Veaceslav Falico
2013-08-05 8:12 ` Nikolay Aleksandrov
2013-08-05 19:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FDB9C7.4090703@redhat.com \
--to=nikolay@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox