From: Vlad Yasevich <vyasevich@gmail•com>
To: Daniel Borkmann <dborkman@redhat•com>
Cc: davem@davemloft•net, kheiss@gmail•com, netdev@vger•kernel.org,
linux-sctp@vger•kernel.org, Neil Horman <nhorman@tuxdriver•com>
Subject: Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state
Date: Fri, 09 Aug 2013 09:39:45 -0400 [thread overview]
Message-ID: <5204F121.7080609@gmail.com> (raw)
In-Reply-To: <1376053748-31783-1-git-send-email-dborkman@redhat.com>
On 08/09/2013 09:09 AM, Daniel Borkmann wrote:
> The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd
> should be 1 MTU. So, instead of 1, set it to 1 MTU.
>
> [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
>
> Reported-by: Karl Heiss <kheiss@gmail•com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat•com>
> Cc: Neil Horman <nhorman@tuxdriver•com>
> ---
> net/sctp/associola.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/associola.c b/net/sctp/associola.c
> index bce5b79..ab67efc 100644
> --- a/net/sctp/associola.c
> +++ b/net/sctp/associola.c
> @@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
> else
> spc_state = SCTP_ADDR_AVAILABLE;
> /* Don't inform ULP about transition from PF to
> - * active state and set cwnd to 1, see SCTP
> + * active state and set cwnd to 1 MTU, see SCTP
> * Quick failover draft section 5.1, point 5
> */
> if (transport->state == SCTP_PF) {
> ulp_notify = false;
> - transport->cwnd = 1;
> + transport->cwnd = asoc->pathmtu;
> }
> transport->state = SCTP_ACTIVE;
> break;
>
Acked-by: Vlad Yasevich <vyasevich@gmail•com>
-vlad
next prev parent reply other threads:[~2013-08-09 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 13:09 [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state Daniel Borkmann
2013-08-09 13:39 ` Vlad Yasevich [this message]
2013-08-13 5:12 ` David Miller
2013-08-11 16:16 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204F121.7080609@gmail.com \
--to=vyasevich@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=kheiss@gmail$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox