From: Jussi Kivilinna <jussi.kivilinna@iki•fi>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, gregkh@linuxfoundation•org,
linux-usb@vger•kernel.org
Subject: Re: [PATCH 1/2] net/usb: catc: allocate URB setup_packet as separate buffer
Date: Sat, 10 Aug 2013 10:31:11 +0300 [thread overview]
Message-ID: <5205EC3F.3080700@iki.fi> (raw)
In-Reply-To: <20130809.134222.2239756285423925844.davem@davemloft.net>
On 09.08.2013 23:42, David Miller wrote:
> From: Jussi Kivilinna <jussi.kivilinna@iki•fi>
> Date: Wed, 07 Aug 2013 16:26:29 +0300
>
>> URB setup packet must not be allocated as part of larger structure
>> because DMA coherence issues.
>>
>> Patch changes catc to allocate ctrl_dr member as separate buffer.
>>
>> Patch is only compile tested.
>>
>> Cc: <stable@vger•kernel.org>
>> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki•fi>
>
> I absolutely do not agree with your adding the stable CC: tag for
> a patch which has only been compile tested.
Agreed, this was not brightest of ideas. I won't do it again.
-Jussi
>
> This applies to all of your other patches you submitted in this
> cluster too.
>
prev parent reply other threads:[~2013-08-10 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 13:26 [PATCH 1/2] net/usb: catc: allocate URB setup_packet as separate buffer Jussi Kivilinna
2013-08-07 13:26 ` [PATCH 2/2] net/usb: catc: allocate URB transfer_buffers as separate buffers Jussi Kivilinna
[not found] ` <20130807132629.14001.2370.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2013-08-09 20:42 ` [PATCH 1/2] net/usb: catc: allocate URB setup_packet as separate buffer David Miller
2013-08-10 7:31 ` Jussi Kivilinna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5205EC3F.3080700@iki.fi \
--to=jussi.kivilinna@iki$(echo .)fi \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox