Subject: Re: [PATCH net] skge: dma_sync the whole receive buffer

From: poma <[email-masked]>
Date: Sun, 11 Aug 2013 06:23:59 +0200

On 11.08.2013 00:02, Stephen Hemminger wrote:
> The DMA sync should sync the whole receive buffer, not just
> part of it. Fixes log messages dma_sync_check.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>
> 
> --- a/drivers/net/ethernet/marvell/skge.c	2013-08-10 14:54:13.184737163 -0700
> +++ b/drivers/net/ethernet/marvell/skge.c	2013-08-10 14:54:54.908099676 -0700
> @@ -3077,11 +3077,13 @@ static struct sk_buff *skge_rx_get(struc
>  
>  		pci_dma_sync_single_for_cpu(skge->hw->pdev,
>  					    dma_unmap_addr(e, mapaddr),
> -					    len, PCI_DMA_FROMDEVICE);
> +					    dma_unmap_len(e, maplen),
> +					    PCI_DMA_FROMDEVICE);
>  		skb_copy_from_linear_data(e->skb, skb->data, len);
>  		pci_dma_sync_single_for_device(skge->hw->pdev,
>  					       dma_unmap_addr(e, mapaddr),
> -					       len, PCI_DMA_FROMDEVICE);
> +					       dma_unmap_len(e, maplen),
> +					       PCI_DMA_FROMDEVICE);
>  		skge_rx_reuse(e, skge->rx_buf_size);
>  	} else {
>  		struct sk_buff *nskb;
> 

Apart from all these warnings, oopses and kernel crashes, via skge iface
there is no traffic initiated starting from the fourth layer up i.e.
ssh, whatsoever.
Counting from the first patch - 'skge-add-dma_mapping-check.patch'.

Attached are readings after the third patch -
'skge-fix-log-messages-dma_sync_check.patch',
- 'dmesg-t-3.11.0-0.rc4.git4.1.fc20.x86_64-nmap.txt'
- 'dmesg-t-3.11.0-0.rc4.git4.1.fc20.x86_64-modprobe.txt'

Anyway thanks for the effort.

poma