public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: William Manley <william.manley@youview•com>
To: <netdev@vger•kernel.org>, <bcrl@kvack•org>, <yoshfuji@linux-ipv6•org>
Subject: Re: [PATCH net-next] ipv6: make unsolicited report intervals configurable for mld
Date: Mon, 12 Aug 2013 11:16:34 +0100	[thread overview]
Message-ID: <5208B602.4040107@youview.com> (raw)
In-Reply-To: <20130812014859.GA13886@order.stressinduktion.org>

On 12/08/13 02:48, Hannes Frederic Sowa wrote:
> Commit cab70040dfd95ee32144f02fade64f0cb94f31a0 ("net: igmp:
> Reduce Unsolicited report interval to 1s when using IGMPv3") and
> 2690048c01f32bf45d1c1e1ab3079bc10ad2aea7 ("net: igmp: Allow user-space
> configuration of igmp unsolicited report interval") by William Manley made
> igmp unsolicited report intervals configurable per interface and corrected
> the interval of unsolicited igmpv3 report messages resendings to 1s.
>
> Same needs to be done for IPv6:
>
> MLDv1 (RFC2710 7.10.): 10 seconds
> MLDv2 (RFC3810 9.11.): 1 second
>
> Both intervals are configurable via new procfs knobs
> mldv1_unsolicited_report_interval and mldv2_unsolicited_report_interval.
>
> Cc: William Manley<william.manley@youview•com>
> Cc: Benjamin LaHaise<bcrl@kvack•org>
> Cc: YOSHIFUJI Hideaki<yoshfuji@linux-ipv6•org>
> Signed-off-by: Hannes Frederic Sowa<hannes@stressinduktion•org>

Thanks for this.  I'd meant to save you the bother.

> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 7fd8572..158c5e1 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -177,6 +177,8 @@ static struct ipv6_devconf ipv6_devconf __read_mostly = {
>   	.accept_redirects	= 1,
>   	.autoconf		= 1,
>   	.force_mld_version	= 0,
> +	.mldv1_unsolicited_report_interval = 10*HZ,

I think you want spaces around that * operator.

> +	.mldv2_unsolicited_report_interval = HZ,
>   	.dad_transmits		= 1,
>   	.rtr_solicits		= MAX_RTR_SOLICITATIONS,
>   	.rtr_solicit_interval	= RTR_SOLICITATION_INTERVAL,
> @@ -211,6 +213,9 @@ static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = {
>   	.accept_ra		= 1,
>   	.accept_redirects	= 1,
>   	.autoconf		= 1,
> +	.force_mld_version	= 0,

Is this a tidyup or does it make a functional difference to this patch? 
  I suspect the former but I thought I'd check for my own understanding.

> +	.mldv1_unsolicited_report_interval = 10*HZ,

Spaces here as well

Thanks

Will

next prev parent reply	other threads:[~2013-08-12 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  1:48 [PATCH net-next] ipv6: make unsolicited report intervals configurable for mld Hannes Frederic Sowa
2013-08-12  2:23 ` Cong Wang
2013-08-12  3:33   ` [PATCH net-next] net: documentation update for IGMP/MLD unsolicited report interval knobs Hannes Frederic Sowa
2013-08-12  4:08     ` David Miller
2013-08-12 10:16 ` William Manley [this message]
2013-08-12 11:09   ` [PATCH net-next] ipv6: make unsolicited report intervals configurable for mld Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5208B602.4040107@youview.com \
    --to=william.manley@youview$(echo .)com \
    --cc=bcrl@kvack$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=yoshfuji@linux-ipv6$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox