public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Fan Du <fan.du@windriver•com>
To: Steffen Klassert <steffen.klassert@secunet•com>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>
Subject: Re: [PATCHv2 net-next] xfrm: Make xfrm_state timer monotonic
Date: Tue, 13 Aug 2013 16:37:04 +0800	[thread overview]
Message-ID: <5209F030.3050303@windriver.com> (raw)
In-Reply-To: <20130813075519.GN25511@secunet.com>



On 2013年08月13日 15:55, Steffen Klassert wrote:
> On Mon, Aug 12, 2013 at 01:40:07PM +0800, Fan Du wrote:
>>
>>
>> On 2013年08月06日 17:22, Steffen Klassert wrote:
>>> On Tue, Aug 06, 2013 at 02:57:05PM +0800, Fan Du wrote:
>>>> xfrm_state timer should be independent of system clock change,
>>>> so switch to monotonic clock base.
>>>>
>>>
>>> I think a monotonic timer will reintroduce a bug on suspend/resume
>>> that was fixed by commit 9e0d57fd6
>>> (xfrm: SAD entries do not expire correctly after suspend-resume)
>>>
>>> Please make sure that this does not happen.
>>
>> What about using CLOCK_BOOTTIME? it's monotonic, but includes suspend time as well.
>
> As I said, I'm open to everything that fixes your problem and does not
> introduce a regression. I'll consider applying after some testing
> if noone else has objections.

Hi, Steffen

Thanks for your understanding! :)

I happened to bump into CLOCK_BOOTTIME several days ago, so apologize for
eating my words earlier. Changing xfrm_state timer to monotonic does not
solve the problem I've described earlier in:

http://www.spinics.net/lists/netdev/msg245019.html (*1*)

So is there any light of hope for the proposal in (*1*) by using CLOCK_BOOTTIME
instead?


> Thanks!
>
>

-- 
浮沉随浪只记今朝笑

--fan

next prev parent reply	other threads:[~2013-08-13  8:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06  6:57 [PATCH net-next] xfrm: Make xfrm_state timer monotonic Fan Du
2013-08-06  9:22 ` Steffen Klassert
2013-08-12  5:40   ` [PATCHv2 " Fan Du
2013-08-13  7:55     ` Steffen Klassert
2013-08-13  8:37       ` Fan Du [this message]
2013-08-13 10:59         ` Steffen Klassert
2013-08-14 11:34     ` Steffen Klassert
  -- strict thread matches above, loose matches on Subject: below --
2013-08-15  7:49 Fan Du
2013-08-15 21:23 ` David Miller
2013-08-16  9:30   ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5209F030.3050303@windriver.com \
    --to=fan.du@windriver$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=steffen.klassert@secunet$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox