From: Libo Chen <clbchenlibo.chen@huawei•com>
To: David Miller <davem@davemloft•net>
Cc: <mugunthanvnm@ti•com>, <bigeasy@linutronix•de>,
<prabhakar.csengg@gmail•com>, <b-liu@ti•com>,
<netdev@vger•kernel.org>, LKML <linux-kernel@vger•kernel.org>,
Li Zefan <lizefan@huawei•com>
Subject: [PATCH RESEND 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
Date: Wed, 14 Aug 2013 11:40:22 +0800 [thread overview]
Message-ID: <520AFC26.9070508@huawei.com> (raw)
In-Reply-To: <5208E231.60104@huawei.com>
We can use the wrapper functions platform_{get,set}_drvdata() instead of
dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei•com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 16ddfc3..2249b2c 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -421,8 +421,7 @@ bail_out:
static int davinci_mdio_remove(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
- struct davinci_mdio_data *data = dev_get_drvdata(dev);
+ struct davinci_mdio_data *data = platform_get_drvdata(pdev);
if (data->bus) {
mdiobus_unregister(data->bus);
@@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- dev_set_drvdata(dev, NULL);
kfree(data);
--
1.7.1
prev parent reply other threads:[~2013-08-14 3:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 13:25 [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 16:53 ` Mugunthan V N
2013-08-12 18:17 ` Sergei Shtylyov
2013-08-12 20:04 ` David Miller
2013-08-13 1:22 ` Libo Chen
2013-08-13 1:23 ` Libo Chen
2013-08-14 3:40 ` Libo Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520AFC26.9070508@huawei.com \
--to=clbchenlibo.chen@huawei$(echo .)com \
--cc=b-liu@ti$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lizefan@huawei$(echo .)com \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prabhakar.csengg@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox