From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Sharma Bhupesh-B45370 <B45370@freescale•com>
Cc: "'netdev@vger•kernel.org'" <netdev@vger•kernel.org>
Subject: Re: Query: Regarding 8211E Phy module support in drivers/net/phy
Date: Wed, 14 Aug 2013 16:07:40 +0200 [thread overview]
Message-ID: <520B8F2C.5090308@st.com> (raw)
In-Reply-To: <A1A6EA40F8503D48BB002B42BD65974E0A0E6C8C@039-SN2MPN1-012.039d.mgd.msft.net>
On 8/2/2013 8:50 PM, Sharma Bhupesh-B45370 wrote:
> Hi Peppe,
>
> This regarding the patch prepared by you for adding RTL8211E support in
> drivers/net/phy/realtek.c
>
> commit ef3d90491a15f0d5cf1ec39a38a45dac6968fb2a
> Author: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
> Date: Wed Jan 23 00:30:03 2013 +0000
>
> net: phy: realtek: add rtl8211e driver
>
> This patch adds the minimal driver to manage the
> Realtek RTL8211E 10/100/1000 Transceivers.
>
> I see a macro specific to 8211E:
> +#define RTL8211E_INER_LINK_STAT 0x10
>
> I was having a look at the RTL8211E(G) datasheet and could see
> the following bit positions for INER register (Address 0x12):
>
> [7:1] as Reserved
> [0] as Jabber Interrupt
>
> If I am not wrong a value 0x10 written to the INER register tries to set bit [4] which seems
> Reserved.
Hello Sharma
you are right RTL8211E_INER_LINK_STAT should be 0x400
I will test it again (just to find the hw) and prepare/send a new patch.
Many thanks
peppe
>
> Or am I missing something here.
> Please let me know your views on the same.
>
> Thanks,
> Bhupesh
>
>
>
next prev parent reply other threads:[~2013-08-14 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 18:50 Query: Regarding 8211E Phy module support in drivers/net/phy Sharma Bhupesh-B45370
2013-08-14 14:07 ` Giuseppe CAVALLARO [this message]
2013-08-14 20:18 ` Sharma Bhupesh-B45370
[not found] ` <A1A6EA40F8503D48BB002B42BD65974E0A111CD2@039-SN2MPN1-013.039d.mgd.msft.net>
2013-08-30 11:18 ` Sharma Bhupesh-B45370
2013-08-19 6:48 ` [PATCH (net.git)] net: phy: rtl8211: fix interrupt on status link change Giuseppe CAVALLARO
2013-08-21 0:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B8F2C.5090308@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=B45370@freescale$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox