From: Felix Fietkau <nbd@openwrt•org>
To: OpenWrt Development List <openwrt-devel@lists•openwrt.org>
Cc: Network Development <netdev@vger•kernel.org>,
Jonas Gorski <jogo@openwrt•org>,
Hauke Mehrtens <hauke@hauke-m•de>
Subject: Re: [RFC][PATCH 2/2] bgmac: pass received packet to the netif instead of copying it
Date: Thu, 15 Aug 2013 13:47:34 +0200 [thread overview]
Message-ID: <520CBFD6.6030600@openwrt.org> (raw)
In-Reply-To: <CACna6rwtLw-Aiz3amMvTBwWsi0OWo5f2yMCF9e8DeCjKLOGDEA@mail.gmail.com>
On 2013-08-15 1:36 PM, Rafał Miłecki wrote:
> 2013/8/11 Rafał Miłecki <zajec5@gmail•com>:
>> It makes more sense to allocate new (empty) skb and pass it to the
>> hardware. That way we avoid copying whole packet into new skb which
>> should result in better performance.
>
> I did some testing of this patch using "perf" tool and iperf -s
> running on the OpenWrt machine (with bgmac supported hardware).
>
> So you can see that __copy_user_common usage has really decreased with
> this patch!
>
> Unfortunately it didn't result in better performance... no idea why :(
Running iperf on the router is not useful as an indicator of routing
performance. Please focus on tests where you only push traffic through
the router, not directly to it.
- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists•openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
next prev parent reply other threads:[~2013-08-15 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 17:49 [RFC][PATCH 1/2] bgmac: separate RX desc setup code into new function Rafał Miłecki
2013-08-11 17:49 ` [RFC][PATCH 2/2] bgmac: pass received packet to the netif instead of copying it Rafał Miłecki
2013-08-15 11:36 ` Rafał Miłecki
2013-08-15 11:47 ` Felix Fietkau [this message]
2013-08-15 20:21 ` Rafał Miłecki
2013-08-18 21:06 ` [OpenWrt-Devel] " Rafał Miłecki
2013-08-19 4:36 ` Felix Fietkau
2013-08-19 17:20 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520CBFD6.6030600@openwrt.org \
--to=nbd@openwrt$(echo .)org \
--cc=hauke@hauke-m$(echo .)de \
--cc=jogo@openwrt$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=openwrt-devel@lists$(echo .)openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox