Subject: Re: [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support

From: Sergei Shtylyov <[email-masked]>
Date: Sat, 17 Aug 2013 03:46:49 +0400

Hello.

On 08/16/2013 09:00 PM, Denis Kirjanov wrote:

    I'd rather name the patch "sundance: add netpoll support". "net-next:" 
shouldn't be there twice definitely.

> Signed-off-by: Denis Kirjanov <[email-masked]>
> ---
>   drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

> diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c
> index 50d9c63..2688a84 100644
> --- a/drivers/net/ethernet/dlink/sundance.c
> +++ b/drivers/net/ethernet/dlink/sundance.c
[...]
> @@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
>   	.ndo_change_mtu		= change_mtu,
>   	.ndo_set_mac_address 	= sundance_set_mac_addr,
>   	.ndo_validate_addr	= eth_validate_addr,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +	.ndo_poll_controller = sundance_poll_controller,

    Could you align = here with the reset of initializers?

> +#endif

WBR, Sergei