From: Sekhar Nori <nsekhar@ti•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail•com>,
DLOS <davinci-linux-open-source@linux•davincidsp.com>,
<netdev@vger•kernel.org>, <devicetree@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet
Date: Sun, 18 Aug 2013 22:25:13 +0530 [thread overview]
Message-ID: <5210FC71.3010600@ti.com> (raw)
In-Reply-To: <520E7377.1080808@cogentembedded.com>
On 8/17/2013 12:16 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/16/2013 06:11 PM, Lad, Prabhakar wrote:
>
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail•com>
>
>> Add ethernet device tree node information and pinmux for mii to da850 by
>> providing interrupt details and local mac address.
>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail•com>
>> ---
>> arch/arm/boot/dts/da850-evm.dts | 5 +++++
>> arch/arm/boot/dts/da850.dtsi | 30 ++++++++++++++++++++++++++++++
>> 2 files changed, 35 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/da850-evm.dts
>> b/arch/arm/boot/dts/da850-evm.dts
>> index 1f8cfdd..44f3fbc 100644
>> --- a/arch/arm/boot/dts/da850-evm.dts
>> +++ b/arch/arm/boot/dts/da850-evm.dts
>> @@ -96,6 +96,11 @@
>> pinctrl-0 = <&mdio_pins>;
>> bus_freq = <2200000>;
>> };
>> + ethernet: emac@1e20000 {
>
> Why label the node in the board file too?
May be not required, but all other entries in da850-evm.dts have labels
too. Other .dts files like am335x-bone.dts use labels too (even though
they are never used in references). So I am inclined to let this be like
this and if needed have all the labels removed through a separate patch
- at least we remain consistent within the file that way.
Prabhakar,
Please mind the new e-mail address of the devicetree list.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-08-18 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 14:11 [PATCH v5 0/2] ARM: davinci: da850: add ethernet driver DT support Lad, Prabhakar
[not found] ` <1376662262-21795-1-git-send-email-prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-16 14:11 ` [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet Lad, Prabhakar
[not found] ` <1376662262-21795-2-git-send-email-prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-16 16:08 ` Sekhar Nori
2013-08-16 18:46 ` Sergei Shtylyov
2013-08-18 16:55 ` Sekhar Nori [this message]
2013-08-16 14:11 ` [PATCH v5 2/2] ARM: davinci: da850: add OF_DEV_AUXDATA entry for davinci_emac Lad, Prabhakar
[not found] ` <1376662262-21795-3-git-send-email-prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-16 16:14 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5210FC71.3010600@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=davinci-linux-open-source@linux$(echo .)davincidsp.com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prabhakar.csengg@gmail$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox