Subject: Re: [PATCH net-next 2/3] net/mlx4_en: Notify user when TX ring in error state

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 19 Aug 2013 22:49:50 +0400

Hello.

On 08/19/2013 10:42 AM, Amir Vadai wrote:

> When hardware gets into error state, must notify user about it.
> When QP in error state no traffic will be tx'ed from the attached
> tx_ring.

> Driver should know how to recover from this unexpected state. I will send later
> on the recovery flow, but having the print shouldn't be delayed.

> Signed-off-by: Amir Vadai <[email-masked]>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 ++++++++
>   1 file changed, 8 insertions(+)

> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> index 6dcca98..157bcd1 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> @@ -362,6 +362,14 @@ static void mlx4_en_process_tx_cq(struct net_device *dev, struct mlx4_en_cq *cq)
>   		 */
>   		rmb();
>
> +		if (unlikely((cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) ==
> +			     MLX4_CQE_OPCODE_ERROR)) {
> +			struct mlx4_err_cqe *cqe_err = (struct mlx4_err_cqe *)cqe;

    Empty line wouldn't hurt here, after declaration.

> +			en_err(priv, "CQE error - vendor syndrom: 0x%x syndrom: 0x%x\n",

    s/syndrom/syndrome/ as below?

> +			       cqe_err->vendor_err_syndrome,
> +			       cqe_err->syndrome);
> +		}
> +

WBR, Sergei