Subject: Re: [PATCH] ipv6: handle Redirect ICMP Message with no Redirected Header option

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 19 Aug 2013 23:00:36 +0400

Hello.

On 08/19/2013 02:54 PM, Duan Jiong wrote:

> From: Duan Jiong <[email-masked]>

> rfc 4861 says the Redirected Header option is optional, so
> the kernel should not drop the Redirect Message that has no
> Redirected Header option. In this patch, the function
> ip6_redirect_no_header() is introduced to deal with that
> condition.

> Signed-off-by: Duan Jiong <[email-masked]>
[...]

> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index b70f897..9934b87 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1178,6 +1178,27 @@ void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark)
>   }
>   EXPORT_SYMBOL_GPL(ip6_redirect);
>   
> +void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif, u32 mark)
> +{
> +	const struct ipv6hdr *iph = (struct ipv6hdr *) skb_network_header(skb);
> +	struct rd_msg *msg = (struct rd_msg *)skb_transport_header(skb);

   Be consistent please: either put space after a typecast or not.

> +	struct dst_entry *dst;
> +	struct flowi6 fl6;

WBR, Sergei