From: Casey Schaufler <casey@schaufler-ca•com>
To: David Miller <davem@davemloft•net>
Cc: amwang@redhat•com, netdev@vger•kernel.org,
james.l.morris@oracle•com, sds@tycho•nsa.gov,
eparis@parisplace•org, pmoore@redhat•com,
linux-kernel@vger•kernel.org,
linux-security-module@vger•kernel.org
Subject: Re: [Patch net-next v3 9/9] selinux: use generic union inet_addr
Date: Mon, 19 Aug 2013 14:42:55 -0700 [thread overview]
Message-ID: <5212915F.20905@schaufler-ca.com> (raw)
In-Reply-To: <20130819.125026.636442915180863272.davem@davemloft.net>
On 8/19/2013 12:50 PM, David Miller wrote:
> It's so that you can pass a generic ipv4/ipv6 address blob into
> things like printf formatting, and since there is an address family
> member present, it knows what's in there and therefore one printf
> format specifier can handle both ipv4 and ipv6 addresses.
The patch message needs to say that, then.
> Like you, I think these changes a complete waste of time too, I'm just
> relaying what I was told.
Well, they certainly don't appear to add any value on their own.
I also generally oppose doing clever things with data structures.
I recently got bitten by the "obvious" relationships between
sockaddr, sockaddr_in and sockaddr_in6, and I've been doing this
stuff since before ioctl was invented.
next prev parent reply other threads:[~2013-08-19 21:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 10:14 [Patch net-next v3 0/9] net: introduce generic type and helpers for IP address Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 1/9] net: introduce generic union inet_addr Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 2/9] net: rename '%pIS' to '%pIA' for " Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 3/9] net: introduce generic simple_inet_pton() Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 4/9] inetpeer: use generic struct in_addr_gen Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 5/9] bridge: " Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 6/9] sunrpc: use generic union inet_addr Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions Cong Wang
[not found] ` <1376907278-26377-8-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-19 14:37 ` Christoph Hellwig
2013-08-19 10:14 ` [Patch net-next v3 8/9] sctp: use generic union inet_addr Cong Wang
2013-08-19 15:05 ` Vlad Yasevich
2013-08-19 10:14 ` [Patch net-next v3 9/9] selinux: " Cong Wang
2013-08-19 19:34 ` Casey Schaufler
2013-08-19 19:50 ` David Miller
2013-08-19 21:42 ` Casey Schaufler [this message]
2013-08-20 6:48 ` David Miller
2013-08-20 13:01 ` Cong Wang
2013-08-20 14:28 ` Casey Schaufler
2013-08-20 14:48 ` Markku Savela
2013-08-22 5:03 ` Cong Wang
2013-08-21 6:11 ` [Patch net-next v3 0/9] net: introduce generic type and helpers for IP address David Miller
2013-08-22 4:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212915F.20905@schaufler-ca.com \
--to=casey@schaufler-ca$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eparis@parisplace$(echo .)org \
--cc=james.l.morris@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pmoore@redhat$(echo .)com \
--cc=sds@tycho$(echo .)nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox