From: Amir Vadai <amirv@mellanox•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: "David S. Miller" <davem@davemloft•net>, <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 2/3] net/mlx4_en: Notify user when TX ring in error state
Date: Tue, 20 Aug 2013 10:55:20 +0300 [thread overview]
Message-ID: <521320E8.9020109@mellanox.com> (raw)
In-Reply-To: <521268CE.7040508@cogentembedded.com>
On 19/08/2013 21:49, Sergei Shtylyov wrote:
> Hello.
>
> On 08/19/2013 10:42 AM, Amir Vadai wrote:
>
>> When hardware gets into error state, must notify user about it.
>> When QP in error state no traffic will be tx'ed from the attached
>> tx_ring.
>
>> Driver should know how to recover from this unexpected state. I will
>> send later
>> on the recovery flow, but having the print shouldn't be delayed.
>
>> Signed-off-by: Amir Vadai <amirv@mellanox•com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
>> b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
>> index 6dcca98..157bcd1 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
>> @@ -362,6 +362,14 @@ static void mlx4_en_process_tx_cq(struct
>> net_device *dev, struct mlx4_en_cq *cq)
>> */
>> rmb();
>>
>> + if (unlikely((cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) ==
>> + MLX4_CQE_OPCODE_ERROR)) {
>> + struct mlx4_err_cqe *cqe_err = (struct mlx4_err_cqe *)cqe;
>
> Empty line wouldn't hurt here, after declaration.
>
>> + en_err(priv, "CQE error - vendor syndrom: 0x%x syndrom:
>> 0x%x\n",
>
> s/syndrom/syndrome/ as below?
>
>> + cqe_err->vendor_err_syndrome,
>> + cqe_err->syndrome);
>> + }
>> +
>
> WBR, Sergei
>
>
Thanks - will be fixed for V1
Amir
next prev parent reply other threads:[~2013-08-20 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 6:42 [PATCH net-next 0/3] Mellanox driver updates 2013-08-19 Amir Vadai
2013-08-19 6:42 ` [PATCH net-next 1/3] net/mlx4_en: Disable global flow control when PFC enabled Amir Vadai
2013-08-19 6:42 ` [PATCH net-next 2/3] net/mlx4_en: Notify user when TX ring in error state Amir Vadai
2013-08-19 18:49 ` Sergei Shtylyov
2013-08-20 7:55 ` Amir Vadai [this message]
2013-08-19 6:42 ` [PATCH net-next 3/3] net/mlx4_en: Fix handling of dma_map failure Amir Vadai
2013-08-19 20:42 ` Francois Romieu
2013-08-20 8:17 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521320E8.9020109@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox