From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Michal Schmidt <mschmidt@redhat•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
Himanshu Madhani <himanshu.madhani@qlogic•com>,
Rajesh Borundia <rajesh.borundia@qlogic•com>,
Shahed Shaikh <shahed.shaikh@qlogic•com>,
Jitendra Kalsaria <jitendra.kalsaria@qlogic•com>,
Sony Chacko <sony.chacko@qlogic•com>,
Sucheta Chakraborty <sucheta.chakraborty@qlogic•com>,
linux-driver@qlogic•com
Subject: Re: [PATCH 4/4] qlcnic: use standard NAPI weights
Date: Wed, 21 Aug 2013 22:19:04 +0400 [thread overview]
Message-ID: <52150498.1090805@cogentembedded.com> (raw)
In-Reply-To: <1377103771-1590-5-git-send-email-mschmidt@redhat.com>
On 08/21/2013 08:49 PM, Michal Schmidt wrote:
> Since commit 82dc3c63 netif_napi_add() produces an error message if
Likewise, summary line is needed.
> a NAPI poll weight greater than 64 is requested.
> qlcnic requests the weight as large as 256 for some of its rings, and
> smaller values for other rings. For instance in qlcnic_82xx_napi_add()
> I think the intention was to give the tx+rx ring a bigger weight than
> to rx-only rings, but it's actually doing the opposite. So I'm assuming
> the weights do not really matter much.
> Just use the standard NAPI weights for all rings.
> Signed-off-by: Michal Schmidt <mschmidt@redhat•com>
> CC: Himanshu Madhani <himanshu.madhani@qlogic•com>
> CC: Rajesh Borundia <rajesh.borundia@qlogic•com>
> CC: Shahed Shaikh <shahed.shaikh@qlogic•com>
> CC: Jitendra Kalsaria <jitendra.kalsaria@qlogic•com>
> CC: Sony Chacko <sony.chacko@qlogic•com>
> CC: Sucheta Chakraborty <sucheta.chakraborty@qlogic•com>
> CC: linux-driver@qlogic•com
WBR, Sergei
next prev parent reply other threads:[~2013-08-21 18:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 16:49 [PATCH 0/4] drivers/net: fix too big NAPI weights Michal Schmidt
2013-08-21 16:49 ` [PATCH 1/4] jme: lower NAPI weight Michal Schmidt
2013-08-21 18:15 ` Sergei Shtylyov
2013-08-23 13:40 ` [PATCH v2 " Michal Schmidt
2013-08-27 19:00 ` David Miller
2013-08-21 16:49 ` [PATCH 2/4] netxen: " Michal Schmidt
2013-08-21 18:16 ` Sergei Shtylyov
2013-08-23 13:41 ` [PATCH v2 " Michal Schmidt
2013-08-27 19:00 ` David Miller
2013-08-21 16:49 ` [PATCH 3/4] ps3_gelic: " Michal Schmidt
2013-08-21 18:17 ` Sergei Shtylyov
2013-08-21 21:03 ` Geoff Levand
2013-08-23 13:41 ` [PATCH v2 " Michal Schmidt
2013-08-27 19:00 ` David Miller
2013-08-21 16:49 ` [PATCH 4/4] qlcnic: use standard NAPI weights Michal Schmidt
2013-08-21 18:19 ` Sergei Shtylyov [this message]
2013-08-22 6:51 ` Himanshu Madhani
2013-08-23 13:45 ` Michal Schmidt
2013-08-30 19:21 ` Himanshu Madhani
2013-09-04 13:03 ` [PATCH net-next v2] " Michal Schmidt
2013-09-05 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52150498.1090805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=himanshu.madhani@qlogic$(echo .)com \
--cc=jitendra.kalsaria@qlogic$(echo .)com \
--cc=linux-driver@qlogic$(echo .)com \
--cc=mschmidt@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rajesh.borundia@qlogic$(echo .)com \
--cc=shahed.shaikh@qlogic$(echo .)com \
--cc=sony.chacko@qlogic$(echo .)com \
--cc=sucheta.chakraborty@qlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox