Subject: Re: [net-next v2 2/8] i40e: transmit, receive, and napi

From: Stefan Assmann <[email-masked]>
Date: Sat, 24 Aug 2013 11:31:24 +0200

On 23.08.2013 20:04, David Miller wrote:
> From: Stefan Assmann <[email-masked]>
> Date: Fri, 23 Aug 2013 14:42:07 +0200
>
>> On 23.08.2013 04:15, Jeff Kirsher wrote:
>>> From: Jesse Brandeburg <[email-masked]>
>>>
>>> This patch contains the transmit, receive, and napi routines, as well
>>> as ancillary routines.
>>>
>>> This file is code that is (will be) shared between the VF and PF
>>> drivers.
>>
>> Just some small nitpicks.
>>
>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>>> new file mode 100644
>>> index 0000000..ceafef0
>>> --- /dev/null
>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>>
>> [...]
>>
>>> +static void i40e_receive_skb(struct i40e_ring *rx_ring,
>>> +			     struct sk_buff *skb, u16 vlan_tag)
>>> +{
>>> +	struct i40e_vsi *vsi = rx_ring->vsi;
>>> +	struct i40e_q_vector *q_vector = rx_ring->q_vector;
>>> +	u64 flags = vsi->back->flags;
>>> +
>>> +	if (vlan_tag & VLAN_VID_MASK)
>>> +		__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
>>
>> Suggesting __constant_htons instead of htons here.
>
> We don't suggest that anymore, because it's completely unnecessary
> with the way the macros are implemented.
>

Okay, good to know. I see it being used frequently in igb, ixgbe so my
assumption was it's the way to go.

   Stefan