From: David Daney <ddaney@caviumnetworks•com>
To: Ben Hutchings <ben@decadent•org.uk>, David Miller <davem@davemloft•net>
Cc: David Daney <ddaney.cavm@gmail•com>,
David Daney <david.daney@cavium•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] bcm87xx: Add MODULE_DEVICE_TABLE
Date: Tue, 3 Sep 2013 12:13:20 -0700 [thread overview]
Message-ID: <522634D0.7080606@caviumnetworks.com> (raw)
In-Reply-To: <20130903185305.GC7729@decadent.org.uk>
On 09/03/2013 11:53 AM, Ben Hutchings wrote:
> On Tue, Sep 03, 2013 at 10:32:02AM -0700, David Daney wrote:
>> On 09/01/2013 02:33 PM, Ben Hutchings wrote:
>>> bcm87xx currently isn't auto-loaded if built as a module.
>>>
>>> Signed-off-by: Ben Hutchings <ben@decadent•org.uk>
>>> ---
>>> Compile-tested only.
>>
>> Then how do you know that it does anything sensible?
>
> This is generally required in modular PHY drivers. I was hoping you'd
> be able to say whether that it's useful or necessary for this one.
OK. I just tested the patch, and it is not sufficient to get the module
loaded automatically.
My configuration also successfully uses drivers/net/phy/marvell.ko, so I
think the modules.alias file is properly generated, and the auto-loading
is working for some PHY drivers, but bcm87xx isn't detected.
I may take a look later this week, but as the patch stands, I don't
think it should be merged.
David Daney
>
>> Other than that, it seems plausible.
>>
>> David Daney
>
> Thanks.
>
> Ben.
>
>>>
>>> Ben.
>>>
>>> drivers/net/phy/bcm87xx.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
>>> index 7997895..f5b44ff 100644
>>> --- a/drivers/net/phy/bcm87xx.c
>>> +++ b/drivers/net/phy/bcm87xx.c
>>> @@ -230,4 +230,11 @@ static void __exit bcm87xx_exit(void)
>>> }
>>> module_exit(bcm87xx_exit);
>>>
>>> +static struct mdio_device_id __maybe_unused bcm87xx_tbl[] = {
>>> + { PHY_ID_BCM8706, 0xffffffff },
>>> + { PHY_ID_BCM8727, 0xffffffff },
>>> + { }
>>> +};
>>> +
>>> MODULE_LICENSE("GPL");
>>> +MODULE_DEVICE_TABLE(mdio, bcm87xx_tbl);
>>>
>>
>
next prev parent reply other threads:[~2013-09-03 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 21:33 [PATCH net-next] bcm87xx: Add MODULE_DEVICE_TABLE Ben Hutchings
2013-09-03 17:32 ` David Daney
2013-09-03 18:53 ` Ben Hutchings
2013-09-03 19:13 ` David Daney [this message]
2013-09-03 19:28 ` David Daney
2013-09-03 20:53 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522634D0.7080606@caviumnetworks.com \
--to=ddaney@caviumnetworks$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=david.daney@cavium$(echo .)com \
--cc=ddaney.cavm@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox