From: annie li <annie.li@oracle•com>
To: Wei Liu <wei.liu2@citrix•com>
Cc: Matt Wilson <msw@linux•com>,
David Vrabel <david.vrabel@citrix•com>,
xen-devel@lists•xen.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
Boris Ostrovsky <boris.ostrovsky@oracle•com>,
Ian Campbell <ian.campbell@citrix•com>,
netdev@vger•kernel.org, msw@amazon•com
Subject: Re: [Xen-devel] xen-netback: count number required slots for an skb more carefully
Date: Wed, 04 Sep 2013 16:06:51 +0800 [thread overview]
Message-ID: <5226EA1B.1030303@oracle.com> (raw)
In-Reply-To: <20130904073857.GI14104@zion.uk.xensource.com>
On 2013-9-4 15:38, Wei Liu wrote:
> On Wed, Sep 04, 2013 at 02:56:20PM +0800, annie li wrote:
>> On 2013-9-4 14:04, Matt Wilson wrote:
>>> On Wed, Sep 04, 2013 at 10:25:59AM +0800, annie li wrote:
>>>> On 2013-9-4 5:53, Wei Liu wrote:
>>> [...]
>>>>> Matt, do you fancy sending the final version? IIRC the commit message
>>>>> needs to be re-written. I personally still prefer Matt's solution as
>>>>> it a) make efficient use of the ring, b) uses ring pointers to
>>>>> calculate slots which is most accurate, c) removes the dependence on
>>>>> MAX_SKB_FRAGS in guest RX path.
>>>>>
>>>>> Anyway, we should get this fixed ASAP.
>>>> Totally agree. This issue is easy to be reproduced with large MTU.
>>>> It is better to upstream the fix soon in case others hit it and
>>>> waste time to fix it.
>>> I'd like to go with Xi's proposed patch that I posed earlier. The main
>>> thing that's kept me from sending a final version is lack of time to
>>> retest against a newer kernel.
>>>
>>> Could someone help out with that? I probably can't get to it until the
>>> end of the week.
>> I can rebase it. Since wei's NAPI &1:1 model patch went into
>> net-next already, it should not be able to applied directly.
>>
> I think this one should go to net then queue up for stable, not
> net-next.
If so, that would be easier. It is almost end of the day here, and I do
not have enough time to test it until tomorrow. Please go ahead with it
if you have time.
Thanks
Annie
> Wei.
>
>> Thanks
>> Annie
>>> Sorry for the delay. :-(
>>>
>>> --msw
next prev parent reply other threads:[~2013-09-04 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 17:29 [PATCH] xen-netback: count number required slots for an skb more carefully David Vrabel
2013-09-03 21:53 ` Wei Liu
2013-09-04 2:25 ` annie li
2013-09-04 6:04 ` Matt Wilson
2013-09-04 6:56 ` [Xen-devel] " annie li
2013-09-04 7:38 ` Wei Liu
2013-09-04 8:06 ` annie li [this message]
2013-09-04 8:20 ` Wei Liu
2013-09-04 8:36 ` Ian Campbell
2013-09-04 8:41 ` Wei Liu
2013-09-04 11:48 ` [PATCH] " David Vrabel
2013-09-04 12:41 ` Ian Campbell
2013-09-04 13:35 ` Wei Liu
2013-09-09 9:20 ` Wei Liu
2013-09-04 13:14 ` Wei Liu
2013-09-04 14:02 ` David Vrabel
2013-09-04 15:44 ` Wei Liu
2013-09-05 10:12 ` David Vrabel
2013-09-05 10:27 ` Wei Liu
2013-09-04 18:48 ` David Miller
2013-09-05 7:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5226EA1B.1030303@oracle.com \
--to=annie.li@oracle$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=david.vrabel@citrix$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=msw@amazon$(echo .)com \
--cc=msw@linux$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox